Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Branch: master
Commits on Nov 3, 2011
  1. Properly initialize FBDialog and Hackbook sample app data

    Christine Abernathy authored
    Related to pull requests
    Test Plan:
    1/ Tested Hackbook iOS app with iPhone 4 device with iOS 5, ran through various
    screens and tested dialog.
    2/ Tested Hackbook iOS app with iPad 2 device with iOS 4.3, ran through various
    screens and tested dialog.
    Reviewers: yariv, brent
    Reviewed By: yariv
    CC: lshepard, yariv
    Differential Revision: 355088
    Revert Plan: OK
    Task ID: 786690
Commits on Nov 2, 2011
  1. @mattdipasquale

    Fix semantic warnings in iOS5 and Xcode 4.2

    mattdipasquale authored Christine Abernathy committed
    Summary: Pulled from facebook#401
    Test Plan:
    1/ Ran on iPhone 4 device with iOS 5, Hackbook iOS app, launched feed dialog,
    rotate all orientations and check works as expected. Also rotated device before
    launching dialog and rotating dialog to see it performed well.
    2/ Ran experiment (1) with iPhone 4.3 simulator.
    3/ Ran experiment (1) with iPad 4.3 simulator.
    4/ Ran experiment (1) with iPad 5.0 simulator.
    Reviewers: yariv, brent
    Reviewed By: yariv
    CC: lshepard, yariv
    Differential Revision: 354600
    Revert Plan: OK
    Task ID: 673148
Commits on Oct 13, 2011
  1. Removing old sample DemoApp.

    Christine Abernathy authored
  2. Handle no friend case for publishing to friend's wall. Small memory l…

    Christine Abernathy authored
    …eak fix, need to release before making savedAPIResult nil first.
  3. Update ignore file, delete files that should be ignored. Fix warning …

    Christine Abernathy authored
    …in UITableViewCell selectionStyle assignment
Commits on Oct 10, 2011
  1. README tweaks

    Christine Abernathy authored
  2. @yariv

    Move the URL scheme suffix parameter from authorize: to init:

    yariv authored
    Summary: Moving the url scheme suffix parameter from authorize: to init:, where
    it fits better, as it behaves in a similar way to appId.
    Test Plan: Modified the demo app to use the new method signatures. Verified SSO
    still worked with and without a url scheme suffix.
    Reviewers: lshepard, brent, caabernathy, teck
    Reviewed By: brent
    CC: brent
    Differential Revision: 335813
  3. Dialog UI improvements, updated README, new sample Hackbook app

    Christine Abernathy authored
Commits on Sep 28, 2011
  1. @yariv

    rename localAppId to urlSchemeSuffix

    yariv authored
    Summary: urlSchemeSuffix is more descriptive and easier to grok than
    Warning: This changes breaks compatibility with the previous version of the SDK. Please update your code to use the latest method signature.
    Test Plan: compiled and ran the demo app with a urlSchemeSuffix configured
    Reviewers: brent, lshepard, teck
    Reviewed By: lshepard
    CC: brent, lshepard
    Differential Revision: 334704
    Task ID: 737701
Commits on Sep 23, 2011
  1. fix project file

    Michal Kijewsi authored
Commits on Sep 13, 2011
  1. @yariv

    This reverts commit 74ae952.

    yariv authored
    The original behavior is the correct behavior as it prevents random errors from popping up the inline login dialog.
Commits on Sep 10, 2011
  1. @lshepard

    Merge pull request #382 from FunkeeMonk/inline_fallback

    lshepard authored
    Fallback to inline authentication dialog if SSO login fails.
Commits on Sep 9, 2011
  1. @FunkeeMonk

    Unless the server indicates a "service_disabled_use_browser" error, f…

    FunkeeMonk authored
    …allback to the inline authentication dialog in -[Facebook handleOpenURL:]
Commits on Aug 29, 2011
  1. @lshepard

    Remove auth.expireSession call from SDK

    lshepard authored
    Summary: The expireSession call was put in as a precaution to make sure that
    apps sessions were really no longer good. However, this is unnecessary and it
    causes issues with apps that were expecting the session to remain usable even
    after the user logged out. So let's remove this call and leave it up to the app
    developer to expire the session if they want.
    Test Plan: Logged in and out of the demo app.
    Reviewed By: trvish
Commits on Aug 26, 2011
  1. README changes only - Documentation update to match init session dele…

    Christine Abernathy authored
    …gate changes. Add notice on issue reporting.
Commits on Aug 15, 2011
  1. @raghuc

    Refactor to init session delegate in Facebook.m constructor

    raghuc authored
    Summary: The change basically just sets the session delegate in the constructor so
    it's available when handleOpenUrl is called.
    Test Plan: Ran the DemoApp and ensured SSO still works.
    Reviewed By: toddkrabach
    Reviewers: seshadri, leon, atishm, toddkrabach, lshepard, caabernathy
    Differential Revision: 297414
    Task ID: 653835
Commits on May 27, 2011
  1. @seshness

    Use the Graph API for the photo uploading example.

    seshness authored
    Edited uploadPhoto to use requestWithGraphPath instead of the legacy REST api
    requestWithMethodName method. Also added the publish_stream permission, which
    needed for uploading photos.
    Test Plan:
    Run the DemoApp and login. Click the upload button and verify that a photo was
    uploaded to the user's Facebook account (pending approval).
    Reviewed By: yariv
    Reviewers: yariv
    CC: yariv
    Differential Revision: 257551
Commits on May 17, 2011
  1. @yariv

    a couple of small cleanups

    yariv authored
  2. @yariv

    small comment fix

    yariv authored
  3. @yariv

    Add the 'localAppId' param to [Facebook authorize]

    yariv authored
    This is the SDK diff to support the local_client_id URL parameter that we added
    to the FB app. I named it 'localAppId' to be consistent with the 'appId'
    parameter to the same function.
    Test Plan:
    bound the demo app to 'fb1234foo' and passed 'foo' as the localAppId value.
    verified the SDK used the 'fbauth2' url scheme to open the fb app and that the
    fb app successfully redirected back to the demo app.
    Reviewed By: brent
    Reviewers: lshepard, atishm, brent, oyamauchi, jimbru
    CC: brent
    Differential Revision: 211201
Commits on Apr 6, 2011
  1. @caabernathy
Commits on Jan 31, 2011
  1. Return FBRequest* from request: methods.

    Jim Brusstar authored
    The request: selectors in the Facebook class now return a pointer to the
    instantiated FBRequest object (rather than void). This makes it easier
    to know in the delegate callback which request the callback maps to.
Commits on Dec 14, 2010
  1. @bgold

    fixing docs link

    bgold authored
Commits on Dec 8, 2010
  1. Updates to README for platform dialogs.

    Jim Brusstar authored
  2. Add app_id to dialog requests.

    Jim Brusstar authored
    Updated the dialog() method to always include app_id. This will prevent
    an error if a dialog is requested and the application doesn't have an
    access token. App_id must now be specified in the Facebook constructor
    as this saves specifying it with every request. Xcode project has been
    updated to build with iOS SDK 4.3.
Commits on Dec 2, 2010
  1. Platform Dialogs Support (UIServer Pretty URLs)

    Jim Brusstar authored
Commits on Dec 1, 2010
  1. @bgold

    added an anchor to dialogs

    bgold authored
Commits on Nov 30, 2010
  1. @yariv

    Prevent dismissWithSuccess:animated from being called twice

    yariv authored Yariv Sadan committed
    Test Plan:
    verified it was called only once
    DiffCamp Revision: 186903
    Reviewed By: brent
    CC: brent
    Revert Plan:
Commits on Nov 23, 2010
  1. @mvernal

    Adding note about plist

    mvernal authored
  2. @mvernal

    Clarifying start instructions

    mvernal authored
Commits on Nov 11, 2010
  1. fix the readme formatting

    Yariv Sadan authored
Commits on Nov 9, 2010
  1. Fix the way the SDK interprets UIWebViewDelegate errors

    Yariv Sadan authored Yariv Sadan committed
    Currently if the facebook app encounters a UIWebViewDelegate error, it passes
    it to the sdk in the error_code parameter. The SDK should know that if this
    parameter is passed, an error occurred, which implies the user *didn't* cancel.
    This fixes it.
    Test Plan:
    disconnected my laptop from the internet, went through the sso flow, verified
    the sdk set userDidCancel to NO before calling [self
    DiffCamp Revision: 180310
    Reviewed By: brent
    CC: brent
    Revert Plan:
Commits on Nov 8, 2010
  1. Updates to README.

    Jim Brusstar authored
    Edits to the documentation for clarity and grammar. This brings
    documentation more in line with Android SDK for consistency.
    arunv, brent, lshepard
    Test Plan:
    All comments--no impact on code.
    DiffCamp Revision: 179248
Commits on Nov 5, 2010
  1. Removing theRunAround Sample App.

    Jim Brusstar authored
    It wasn't particularly useful, so it gets the rm -rf.
    Test Plan:
    Nothing depended on this, so we're good.
    DiffCamp Revision: 179177
    Reviewed By: yariv
    CC: arunv, lshepard, brent, rmcelroy, arice, achao, yariv, bootcamp-diffs@lists
    #431037: Go start-to-finish through iOS SDK and validate
    Revert Plan:
Something went wrong with that request. Please try again.