New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#9) support liquid inside markdownify content #11

Merged
merged 2 commits into from Dec 18, 2016

Conversation

Projects
None yet
2 participants
@ntwcklng
Contributor

ntwcklng commented Sep 18, 2016

This closes #9

@juusaw

This comment has been minimized.

Show comment
Hide comment
@juusaw

juusaw Sep 22, 2016

Owner

Hi there!

This seems to break syntax highlighted code blocks. I get a Liquid error: undefined method 'safe' for nil:NilClass instead of the markup for every block. Can be reproduced by for example adding the following to a blog post

{% highlight ruby %}
puts 'test'
{% endhighlight %}
Owner

juusaw commented Sep 22, 2016

Hi there!

This seems to break syntax highlighted code blocks. I get a Liquid error: undefined method 'safe' for nil:NilClass instead of the markup for every block. Can be reproduced by for example adding the following to a blog post

{% highlight ruby %}
puts 'test'
{% endhighlight %}
@juusaw

Currently breaks syntax highlighted code blocks. This must be addressed before merge.

@ntwcklng

This comment has been minimized.

Show comment
Hide comment
@ntwcklng

ntwcklng Nov 19, 2016

Contributor

Unfortunately i didn't find a solution yet, do you have an idea?

Contributor

ntwcklng commented Nov 19, 2016

Unfortunately i didn't find a solution yet, do you have an idea?

@juusaw

This comment has been minimized.

Show comment
Hide comment
@juusaw

juusaw Dec 5, 2016

Owner

Fixed by #14

Owner

juusaw commented Dec 5, 2016

Fixed by #14

@juusaw juusaw closed this Dec 5, 2016

@juusaw

This comment has been minimized.

Show comment
Hide comment
@juusaw

juusaw Dec 18, 2016

Owner

Accidentally closed without merging. Will merge now, since #14 fixes the comment block problem.

Owner

juusaw commented Dec 18, 2016

Accidentally closed without merging. Will merge now, since #14 fixes the comment block problem.

@juusaw juusaw reopened this Dec 18, 2016

@juusaw

juusaw approved these changes Dec 18, 2016

@juusaw juusaw merged commit 5a77a10 into juusaw:master Dec 18, 2016

@ntwcklng ntwcklng deleted the ntwcklng:fix-liquid-render branch Dec 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment