Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support singular duration terminology. #28

Closed
SevereOverfl0w opened this issue Mar 8, 2019 · 1 comment
Closed

Support singular duration terminology. #28

SevereOverfl0w opened this issue Mar 8, 2019 · 1 comment

Comments

@SevereOverfl0w
Copy link
Contributor

(t/new-duration 1 :minute) doesn't work, given the interface, it feels like it should. Minor semantic thing.

@henryw374
Copy link
Collaborator

in java.time (and ECMA Temporal) singular terminology is always for fields of a Temporal (date thing), e.g. date.getMinute() and plural is always for fields of a TemporalAmount (period, duration). Tick maintains that, so you can know when to use t/minute vs t/minutes.

I worry this change might cause confusion on something already pretty subtle. feel free to reopen with more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants