Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Value transformations #213

Closed
6 tasks
rhazn opened this issue Mar 17, 2023 · 2 comments · Fixed by #320
Closed
6 tasks

[FEATURE] Value transformations #213

rhazn opened this issue Mar 17, 2023 · 2 comments · Fixed by #320
Labels
enhancement New feature or request
Milestone

Comments

@rhazn
Copy link
Contributor

rhazn commented Mar 17, 2023

User Story

  1. As a {user}
  2. I want {to solve exercise 4}
  3. So that {I can get a good grade in AMSE}

User Acceptance Criteria

  • Students read in temperature as Celsius and write it as Fahrenheit
  • Students can read in booleans from 'Ja'/'Nein' strings and write it as boolean
  • Students can read in timespans from ms and write it as seconds

Notes

  • Consider value type readers and writers for the first two UAC

Examples

Definitions of Done

  • A PR has been opened and accepted
  • All user acceptance criteria are met
  • All tests are passing
@rhazn rhazn added the enhancement New feature or request label Mar 17, 2023
@rhazn rhazn added this to the AMSE SS23 milestone Mar 17, 2023
@rhazn rhazn changed the title [FEATURE] Valuetype readers and writers [FEATURE] Value transformations Mar 17, 2023
@georg-schwarz
Copy link
Member

Would the third UAC also be covered by valuetype readers and writers?

@rhazn
Copy link
Contributor Author

rhazn commented Mar 29, 2023

Hmm theoretically yes, if we only solve it with valuetype readers and writers we are missing transformations by a set value though. Technically that is not that bad imho, transforming a value by a multiplication seems like something that is often done to transform it from one representation to another anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants