Permalink
Commits on Sep 15, 2017
  1. [paging-scroll-view] Fix an exception thrown when NIPagingScrollView …

    stephanemoore committed Sep 15, 2017
    …rotates with a zero frame 💥
    
    When -pageScrollableDimension returns 0, _percentScrolledIntoFirstVisiblePage ends up as NaN because of divide-by-zero operations in willRotateToInterfaceOrientation:duration:. This patch guards against these divide-by-zero errors.
    
    Also add tests to catch exceptions thrown when rotating NIPagingScrollView with a zero frame.
Commits on Aug 23, 2017
  1. Update travis.yml with iOS 9.3 SDK.

    jverkoey committed on GitHub Aug 23, 2017
Commits on May 30, 2017
  1. [attributed-label] Link-ordering accessibility fix.

    popzkk committed with stephanemoore May 30, 2017
    Removes logic to ignore spaces and line terminators in the beginning and the end as the user who uses VoiceOver doesn't care the frame is big or small.
    Introducing the unnecessary logic could potentially break tests (e.g. some tests try to find element by a11y label which happens to have a line terminator at the end).
Commits on May 12, 2017
  1. Add an enum property "linksOrdering" to NIAttributedLabel to

    popzkk committed with stephanemoore Nov 17, 2016
     - make it possible for links to be in the original order in VoiceOver.
     - make it possible for links which go over lines to be read only once.
    
    Before:
     - VoiceOver reads the whole label and then reads the links one by one
     - If a link goes over lines then it will be read more than once
    
    After (when LinkOrdering is set to NILinkOrderingOriginal):
     - VoiceOver reads text fragment and links in the original order
     - If a link goes over lines it will only be read once
    
    "linkOrdering" defaults to sort links in the first (the same as before).
Commits on May 7, 2017
  1. [networkimage] Discard canceled operations. (#608)

    haydenhuang committed with jverkoey May 7, 2017
    * [networkimage] Discard canceled operations.
    
    The original fix will not discard canceled operation because the variable
    'operation' and 'pathToNetworkImage' are still pointing to the canceled
    one and thus the comparison will always return true. Fix by using
    self.operation which will get updated whenever there is request.
    
    See #442.
    
    * [networkimage] remove the extra bracket
Commits on Apr 21, 2017
  1. fix multiline label sizing when numberOfLines == 1 (#668)

    jisungna committed with jverkoey Apr 21, 2017
    * fix multiline label sizing when numberOfLines == 1
    
    if numberOfLines ==1, and if the text contains '\n' chars (e.g. @"multiline_start\n\n\n\nmultiline_end"), then the code was returning a size that would fit all the lines. 
    
    the original code's intent was that, if numberOfLines == 1, then -[label sizeToFit] should extend the current width (common use-case) in a single-line, so he made the constraintSize.width unbounded (source: TTTAttributedLabel/TTTAttributedLabel#28).
    
    however, he missed the case where the string itself might contain newline characters; and since he has set constraintSize.height unbounded as well, the size being returned was accounting for all lines in the string despite numberOfLines == 1.
    
    * Add runtime flag to disable the fix by default to support existing clients that may depend on the existing size calculation behavior.
    
    * Add runtime flag to disable the fix by default to support existing clients that may depend on the existing size calculation behavior.
    
    * change BOOL true/false to YES/NO
Commits on Mar 28, 2017
Commits on Oct 12, 2016
  1. PagingScrollView: expose RTL property and use transforms to honor it. (

    marcobgoogle committed with stephanemoore Oct 12, 2016
    …#661)
    
    PagingScrollView: expose RTL property and use transforms to honor it.
Commits on Aug 31, 2016
  1. Merge pull request #658 from stephanemoore/mcvm-bug

    stephanemoore committed on GitHub Aug 31, 2016
    Fix NIMutableCollectionViewModel
Commits on Aug 30, 2016
  1. [collections] Add a unit test target for NimbusCollections and a shar…

    stephanemoore committed Aug 30, 2016
    …ed xcscheme for NimbusCollections.
    
    The unit test target is bootstrapped with a single test of
    NIMutableCollectionViewModel. This test should capture the error
    addressed in PR/651 as well as the error created by the changes in PR/651.
  2. [collections] Fix -[NIMutableCollectionViewModel

    stephanemoore committed Aug 30, 2016
    initWithListArray:delegate:] to construct a mutable backing store for
    rows.
  3. Revert "[models] Return a mutable copy of the rows object."

    stephanemoore committed Aug 30, 2016
    This reverts commit f10856e.
    
    The above commit causes regressions since mutations no longer occur on
    the rows property as new mutable copies are created per invocation of
    the mutableRows method.
  4. Merge pull request #657 from bgeorgescu/patch-1

    stephanemoore committed on GitHub Aug 30, 2016
    Fix NIAttributedLabel race condition relating to deferred auto link detection
  5. Update NIAttributedLabel.m

    bgeorgescu committed on GitHub Aug 30, 2016
Commits on Aug 24, 2016
  1. Fix NIAttributedLabel race condition relating to deferred auto link d…

    bgeorgescu committed on GitHub Aug 24, 2016
    …etection
    
    Fix two race condition issues in NIAttributedLabel relating to deferred auto link detection:
    1) If the label's string is rapidly changed (such as when scrolling and reusing cells), it is possible for the link detection results for a previous string to be applied to a newer, causing out of range errors and resulting in crashes.
    2) In the same circumstances as 1), even if we don't crash, the second string is prevented from having its links detected since the detection for the previous string hasn't finished and detectingLinks is still YES.
  2. Fix some crashes. (#656)

    bogardon committed with jverkoey Aug 24, 2016
    * Fix image height calculations.
    
    Replacement characters used for images need to have the same font as its neighboring text.
    
    * clamp index so it doesn't crash attributedAtIndex
    
    * Fix some crashes.
    
    attributesAtIndex:effectiveRange: can crash if index is out of bounds, this can happen if somehow we're inserting images into a 0 length string.
    addAttribute:value:range: can crash if value is nil
Commits on Aug 16, 2016
  1. Fix image height calculations. (#655)

    bogardon committed with jverkoey Aug 16, 2016
    Replacement characters used for images need to have the same font as its neighboring text.
Commits on Jun 3, 2016
  1. Update NIMutableCollectionViewModel+Private.h (#650)

    aelam committed with jverkoey Jun 3, 2016
    this file is supposed to include `#import "NICollectionViewModel+Private.h"` , otherwise other files included this file will have to `#import "NICollectionViewModel+Private.h"`
  2. [models] Return a mutable copy of the rows object.

    Serlight committed with jverkoey Jun 3, 2016
    if create NIMutableCollectionViewModel using NSArray, then when i attach a array to this model, there will be an error
Commits on Apr 7, 2016
  1. Merge pull request #648 from stephanemoore/schmerps

    jverkoey committed Apr 7, 2016
    [attributedlabel] Fix minor error regarding UIActionSheet deprecation.
Commits on Apr 6, 2016
  1. Merge pull request #646 from jverkoey/fixes-for-dt9

    jverkoey committed Apr 6, 2016
    [attributedlabel] Address various deprecation warnings
Commits on Apr 5, 2016
  1. [attributedlabel] Suppress UIActionSheet deprecation warnings.

    stephanemoore committed Apr 5, 2016
    This change suppresses UIActionSheet deprecation warnings while we evaluate the proper alternative for clients to use.
  2. [attributedlabel] Deprecate -attributedLabel:shouldPresentActionSheet…

    stephanemoore committed Apr 5, 2016
    …:withTextCheckingResult:atPoint:
    
    Deprecate -attributedLabel:shouldPresentActionSheet:withTextCheckingResult:atPoint: on NIAttributedLabelDelegate starting at the iOS 8.3 SDK to match UIKit's UIActionSheet deprecation. An evaluation of alternatives will be a necessary followup.
  3. [attributedlabel] Address deprecations in the NSURLUtilities category.

    stephanemoore committed Apr 5, 2016
    Update NIAttributedLabel to use NIStringByAddingPercentEscapesForURLParameterString instead of -[NSString stringByAddingPercentEscapesUsingEncoding:].
  4. [attributedlabel] Address CoreText deprecations.

    stephanemoore committed Apr 5, 2016
    Migrate from deprecated CTTextAlignment enum values. The replacement enum values are declared as being introduced in iOS 6 SDK so presumably all the iOS SDKs that Nimbus supports should have access to them.
Commits on Mar 29, 2016
  1. Merge pull request #644 from jverkoey/revert-642-master

    jverkoey committed Mar 29, 2016
    Revert "Fix NIAttributedLabel bug: using autolayout with attributedText, the super's intrinsicContentSize is zero"
  2. Revert "Fix NIAttributedLabel bug: using autolayout with attributedTe…

    jverkoey committed Mar 29, 2016
    …xt, the super's intrinsicContentSize is zero"
  3. Merge pull request #642 from lestathc/master

    jverkoey committed Mar 29, 2016
    Fix NIAttributedLabel bug: using autolayout with attributedText, the super's intrinsicContentSize is zero
Commits on Mar 24, 2016
  1. Fix NIAttributedBug: using autolayout with attributedText, the super'…

    Cong Hui(lestathc@google.com) committed Mar 24, 2016
    …s intrinsicContentSize is zero and the result is wrong.
Commits on Mar 15, 2016
  1. Merge pull request #640 from jverkoey/implicit-conversions

    stephanemoore committed Mar 15, 2016
    [attributedlabel] Fix implicit floating point conversions