Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NITitleCellObject's documented designated initializer is incorrect. #476

Closed
stephanemoore opened this issue Dec 6, 2013 · 3 comments
Closed

Comments

@stephanemoore
Copy link
Collaborator

NITitleCellObject documents its designated initializer as being initWithTitle:image:.
This is not actually the case. You can actually call init or initWithCellClass:userInfo: and skip initWithTitle:image: entirely. This can be problematic for subclasses because certain initializer calls can potentially skip a number of initializers that are expected to be called.

@stephanemoore
Copy link
Collaborator Author

Commit 793f2f5 takes care of calls to init.

@jverkoey
Copy link
Owner

jverkoey commented Feb 8, 2014

Added proper designated initializer and updated all init methods to call it accordingly.

@stephanemoore
Copy link
Collaborator Author

I can't let you do that Starfox!

This breaks the previous designated initializer contract along with behavior with subclass overrides of the designated initializer. I'll send out a pull request to address this as soon as I can verify the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants