New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace headers from repository #335

Merged
merged 3 commits into from Feb 14, 2013

Conversation

Projects
None yet
3 participants
@fabb

fabb commented Jan 22, 2013

+Namespace.h header files are generated upon project build and thus should not be in the git repo. Otherwise they can dirty the git folder upon small changes to the project file, which gives unnecessary hassle when having nimbus as a submodule.

In the pull request the namespace header files are removed from the git repository, but not from the project. They are added to gitignore. The generation script is moved before the copy headers section in each target's build phase.

Fabian added some commits Jan 22, 2013

Fabian
removed namespace headers from repository, as they are generated on b…
…uild, and would result in dirty git status when any small thing was changed in the nimbus project
@djMax

This comment has been minimized.

Show comment
Hide comment
@djMax

djMax Feb 14, 2013

Definitely agree with this one... Hope it gets pulled in soon.

djMax commented Feb 14, 2013

Definitely agree with this one... Hope it gets pulled in soon.

jverkoey added a commit that referenced this pull request Feb 14, 2013

Merge pull request #335 from fabb/remove_namespace_headers_from_repos…
…itory

Remove namespace headers from repository

@jverkoey jverkoey merged commit 37fb0dd into jverkoey:master Feb 14, 2013

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Feb 14, 2013

Owner

Thanks!

Owner

jverkoey commented Feb 14, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment