Skip to content

Launcher tap-hold to edit #34

Closed
wants to merge 12 commits into from

4 participants

@rogchap
rogchap commented Aug 8, 2011

Pull request for launcher edit feature.

This feature request is incomplete, but I thought a pull request will help aid comments on features and a place to track changes.

One of the main differences over Three20's launcher is the NILauncherView is agnostic to the data items, therefore the view can no longer be responsible for (for example) delete/close buttons on launch items.

Maintaining the datasource concept we need to implement the drag and drop reordering.

Note to self: look at UITableView's Managing the Reordering of Rows: http://developer.apple.com/library/ios/#documentation/UserExperience/Conceptual/TableView_iPhone/ManageReorderRow/ManageReorderRow.html#

@jverkoey

You may wish to check out the SDK Availability functionality in the core:

http://jverkoey.github.com/nimbus/group___s_d_k-_availability.html#ga622ef4a203e625618b9077c9b1deca24

Implementation (with a similar note about the private API version of gesture recognizers).
http://jverkoey.github.com/nimbus/_n_i_s_d_k_availability_8m_source.html#l00072

Should we add the other gesture recognisers to Nimbus Core?

Also, the function for the tap recognizer class uses NIDeviceOSVersionIsAtLeast.; should we not use the respondsToSelector as instructed by your Attention note??

Owner
Owner

This is a strange case where I think it may be simpler/safer to check the device's SDK version. Allocating a class before we're sure whether it's the correct implementation sounds scarier to me than checking the device SDK.

Been thinking about making accessing the gestures classes easier/scalable, but I can't see a better way than a separate method for each.
All my other thoughts involved strings or enums, which in it self causes other problem.
Also because you want to make sure you maintain the statically created class it would then involve a massive if-else or (shudder...) switch statement.

I think also from an implementation point of view having a method per class would stay in line with all the gesture recognizers being concrete classes.

My only other suggestion is to create methods that only return a BOOL on UIPopoverController/UIGestureRecognizer availability and leave it up to the user to instantiate the class, but I guess that may seem a bit backwards.

@jverkoey
Owner
jverkoey commented Aug 8, 2011

Note: This is related to task #6.

@jverkoey
Owner

Some quick feedback:

  • The wiggling feels slightly too fast compared to the native wiggle.

Next steps just to add some context to this pull request at this milestone:

  • [completed] Tap-and-hold enters the editing mode.
  • [todo] Dragging icons to reorder them (this includes moving icons between pages)
@rogchap
@jverkoey
Owner
@alias1
alias1 commented Sep 29, 2011

Was wondering what the status on this was. Is it basically feature complete except for the 'wiggle speed' question and dragging icons?

@jverkoey
Owner

@alias1 I believe so.

@alias1
alias1 commented Sep 29, 2011

Cool :)

@alias1
alias1 commented Oct 10, 2011

Not sure if this is the right place to mention it, but was thinking that it could be cool to have a 'folders' type feature in the launcher (similar to the one in springboard)

@alias1
alias1 commented Nov 26, 2011

@jverkoey Was wondering when this feature was getting merged into master?

@jverkoey
Owner

Icon dragging must be added in order to make this feature useful, so until that gets built this will have to chill.

@idancali

hey guys, any resolution on this yet?

@jverkoey jverkoey closed this Feb 16, 2014
@jverkoey
Owner

I'm planning to deprecate the Launcher feature due to the fact that, as a platform, iOS apps moved away from launcher-style interfaces long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.