Launcher tap-hold to edit #34

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
4 participants
@rogchap
Contributor

rogchap commented Aug 8, 2011

Pull request for launcher edit feature.

This feature request is incomplete, but I thought a pull request will help aid comments on features and a place to track changes.

One of the main differences over Three20's launcher is the NILauncherView is agnostic to the data items, therefore the view can no longer be responsible for (for example) delete/close buttons on launch items.

Maintaining the datasource concept we need to implement the drag and drop reordering.

Note to self: look at UITableView's Managing the Reordering of Rows: http://developer.apple.com/library/ios/#documentation/UserExperience/Conceptual/TableView_iPhone/ManageReorderRow/ManageReorderRow.html#

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Aug 1, 2011

You may wish to check out the SDK Availability functionality in the core:

http://jverkoey.github.com/nimbus/group___s_d_k-_availability.html#ga622ef4a203e625618b9077c9b1deca24

Implementation (with a similar note about the private API version of gesture recognizers).
http://jverkoey.github.com/nimbus/_n_i_s_d_k_availability_8m_source.html#l00072

You may wish to check out the SDK Availability functionality in the core:

http://jverkoey.github.com/nimbus/group___s_d_k-_availability.html#ga622ef4a203e625618b9077c9b1deca24

Implementation (with a similar note about the private API version of gesture recognizers).
http://jverkoey.github.com/nimbus/_n_i_s_d_k_availability_8m_source.html#l00072

This comment has been minimized.

Show comment
Hide comment
@rogchap

rogchap Aug 1, 2011

Owner

Should we add the other gesture recognisers to Nimbus Core?

Owner

rogchap replied Aug 1, 2011

Should we add the other gesture recognisers to Nimbus Core?

This comment has been minimized.

Show comment
Hide comment
@rogchap

rogchap Aug 1, 2011

Owner

Also, the function for the tap recognizer class uses NIDeviceOSVersionIsAtLeast.; should we not use the respondsToSelector as instructed by your Attention note??

Owner

rogchap replied Aug 1, 2011

Also, the function for the tap recognizer class uses NIDeviceOSVersionIsAtLeast.; should we not use the respondsToSelector as instructed by your Attention note??

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Aug 1, 2011

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Aug 1, 2011

This is a strange case where I think it may be simpler/safer to check the device's SDK version. Allocating a class before we're sure whether it's the correct implementation sounds scarier to me than checking the device SDK.

This is a strange case where I think it may be simpler/safer to check the device's SDK version. Allocating a class before we're sure whether it's the correct implementation sounds scarier to me than checking the device SDK.

This comment has been minimized.

Show comment
Hide comment
@rogchap

rogchap Aug 2, 2011

Owner

Been thinking about making accessing the gestures classes easier/scalable, but I can't see a better way than a separate method for each.
All my other thoughts involved strings or enums, which in it self causes other problem.
Also because you want to make sure you maintain the statically created class it would then involve a massive if-else or (shudder...) switch statement.

I think also from an implementation point of view having a method per class would stay in line with all the gesture recognizers being concrete classes.

My only other suggestion is to create methods that only return a BOOL on UIPopoverController/UIGestureRecognizer availability and leave it up to the user to instantiate the class, but I guess that may seem a bit backwards.

Owner

rogchap replied Aug 2, 2011

Been thinking about making accessing the gestures classes easier/scalable, but I can't see a better way than a separate method for each.
All my other thoughts involved strings or enums, which in it self causes other problem.
Also because you want to make sure you maintain the statically created class it would then involve a massive if-else or (shudder...) switch statement.

I think also from an implementation point of view having a method per class would stay in line with all the gesture recognizers being concrete classes.

My only other suggestion is to create methods that only return a BOOL on UIPopoverController/UIGestureRecognizer availability and leave it up to the user to instantiate the class, but I guess that may seem a bit backwards.

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Aug 8, 2011

Owner

Note: This is related to task #6.

Owner

jverkoey commented Aug 8, 2011

Note: This is related to task #6.

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Aug 14, 2011

Owner

Some quick feedback:

  • The wiggling feels slightly too fast compared to the native wiggle.

Next steps just to add some context to this pull request at this milestone:

  • [completed] Tap-and-hold enters the editing mode.
  • [todo] Dragging icons to reorder them (this includes moving icons between pages)
Owner

jverkoey commented Aug 14, 2011

Some quick feedback:

  • The wiggling feels slightly too fast compared to the native wiggle.

Next steps just to add some context to this pull request at this milestone:

  • [completed] Tap-and-hold enters the editing mode.
  • [todo] Dragging icons to reorder them (this includes moving icons between pages)
@rogchap

This comment has been minimized.

Show comment
Hide comment
@rogchap

rogchap Aug 14, 2011

Contributor

Do you really think it's too fast? I tried to match it as closely to the springboard as possible. It is faster than three20's, but that always felt like a slowly rocking boat rather than a wiggle :)

I'll do some side by side comparisons, and I can slow it down if needs be.

Sent from my iPhone

On 14 Aug 2011, at 04:08, jverkoeyreply@reply.github.com wrote:

Some quick feedback:

  • The wiggling feels slightly too fast compared to the native wiggle.

Next steps just to add some context to this pull request at this milestone:

  • [completed] Tap-and-hold enters the editing mode.
  • [todo] Dragging icons to reorder them (this includes moving icons between pages)

Reply to this email directly or view it on GitHub:
#34 (comment)

Contributor

rogchap commented Aug 14, 2011

Do you really think it's too fast? I tried to match it as closely to the springboard as possible. It is faster than three20's, but that always felt like a slowly rocking boat rather than a wiggle :)

I'll do some side by side comparisons, and I can slow it down if needs be.

Sent from my iPhone

On 14 Aug 2011, at 04:08, jverkoeyreply@reply.github.com wrote:

Some quick feedback:

  • The wiggling feels slightly too fast compared to the native wiggle.

Next steps just to add some context to this pull request at this milestone:

  • [completed] Tap-and-hold enters the editing mode.
  • [todo] Dragging icons to reorder them (this includes moving icons between pages)

Reply to this email directly or view it on GitHub:
#34 (comment)

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Aug 14, 2011

Owner

Haha, I'm honestly not sure whether it's too fast or not now. It "feels" fast, but you have a point in that I'm likely really used to the three20 boat-rocking wiggle. Your call totally :)

On 2011-08-14, at 1:09 AM, rogchapreply@reply.github.com wrote:

Do you really think it's too fast? I tried to match it as closely to the springboard as possible. It is faster than three20's, but that always felt like a slowly rocking boat rather than a wiggle :)

I'll do some side by side comparisons, and I can slow it down if needs be.

Sent from my iPhone

On 14 Aug 2011, at 04:08, jverkoeyreply@reply.github.com wrote:

Some quick feedback:

  • The wiggling feels slightly too fast compared to the native wiggle.

Next steps just to add some context to this pull request at this milestone:

  • [completed] Tap-and-hold enters the editing mode.
  • [todo] Dragging icons to reorder them (this includes moving icons between pages)

Reply to this email directly or view it on GitHub:
#34 (comment)

Reply to this email directly or view it on GitHub:
#34 (comment)

Owner

jverkoey commented Aug 14, 2011

Haha, I'm honestly not sure whether it's too fast or not now. It "feels" fast, but you have a point in that I'm likely really used to the three20 boat-rocking wiggle. Your call totally :)

On 2011-08-14, at 1:09 AM, rogchapreply@reply.github.com wrote:

Do you really think it's too fast? I tried to match it as closely to the springboard as possible. It is faster than three20's, but that always felt like a slowly rocking boat rather than a wiggle :)

I'll do some side by side comparisons, and I can slow it down if needs be.

Sent from my iPhone

On 14 Aug 2011, at 04:08, jverkoeyreply@reply.github.com wrote:

Some quick feedback:

  • The wiggling feels slightly too fast compared to the native wiggle.

Next steps just to add some context to this pull request at this milestone:

  • [completed] Tap-and-hold enters the editing mode.
  • [todo] Dragging icons to reorder them (this includes moving icons between pages)

Reply to this email directly or view it on GitHub:
#34 (comment)

Reply to this email directly or view it on GitHub:
#34 (comment)

@0xdevalias

This comment has been minimized.

Show comment
Hide comment
@0xdevalias

0xdevalias Sep 29, 2011

Contributor

Was wondering what the status on this was. Is it basically feature complete except for the 'wiggle speed' question and dragging icons?

Contributor

0xdevalias commented Sep 29, 2011

Was wondering what the status on this was. Is it basically feature complete except for the 'wiggle speed' question and dragging icons?

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Sep 29, 2011

Owner

@alias1 I believe so.

Owner

jverkoey commented Sep 29, 2011

@alias1 I believe so.

@0xdevalias

This comment has been minimized.

Show comment
Hide comment
@0xdevalias

0xdevalias Sep 29, 2011

Contributor

Cool :)

Contributor

0xdevalias commented Sep 29, 2011

Cool :)

@0xdevalias

This comment has been minimized.

Show comment
Hide comment
@0xdevalias

0xdevalias Oct 10, 2011

Contributor

Not sure if this is the right place to mention it, but was thinking that it could be cool to have a 'folders' type feature in the launcher (similar to the one in springboard)

Contributor

0xdevalias commented Oct 10, 2011

Not sure if this is the right place to mention it, but was thinking that it could be cool to have a 'folders' type feature in the launcher (similar to the one in springboard)

@0xdevalias

This comment has been minimized.

Show comment
Hide comment
@0xdevalias

0xdevalias Nov 26, 2011

Contributor

@jverkoey Was wondering when this feature was getting merged into master?

Contributor

0xdevalias commented Nov 26, 2011

@jverkoey Was wondering when this feature was getting merged into master?

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Nov 26, 2011

Owner

Icon dragging must be added in order to make this feature useful, so until that gets built this will have to chill.

Owner

jverkoey commented Nov 26, 2011

Icon dragging must be added in order to make this feature useful, so until that gets built this will have to chill.

@idancali

This comment has been minimized.

Show comment
Hide comment
@idancali

idancali Dec 21, 2012

hey guys, any resolution on this yet?

hey guys, any resolution on this yet?

@jverkoey jverkoey closed this Feb 16, 2014

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Feb 16, 2014

Owner

I'm planning to deprecate the Launcher feature due to the fact that, as a platform, iOS apps moved away from launcher-style interfaces long ago.

Owner

jverkoey commented Feb 16, 2014

I'm planning to deprecate the Launcher feature due to the fact that, as a platform, iOS apps moved away from launcher-style interfaces long ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment