New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes and feature additions #348

Merged
merged 26 commits into from Feb 27, 2013

Conversation

Projects
None yet
2 participants
@djMax

djMax commented Feb 22, 2013

I'm implementing a more realistic sample app and running across various little issues and missing features. This corrects a problem with id-only views and adds support for patterned colors (from resource images). This also add support for UITextField and a simple NITextField that overrides placeholder font and color.

Show outdated Hide outdated examples/css/CSSDemo/RootViewController.m
@@ -66,7 +66,7 @@ - (void)loadView {
],
[[UILabel alloc] init], @".rightMiddleLabel", NILocalizedStringWithDefault(@"RightLabel", @"Right Middle Label"),
[[UILabel alloc] init], @".bottomLabel", NILocalizedStringWithDefault(@"BottomLabel", @"Bottom Left Label"),
_button = [UIButton buttonWithType:UIButtonTypeCustom], NIInvocationWithInstanceTarget(self, @selector(buttonPress)), NILocalizedStringWithDefault(@"TestButton", @"Test Button"), @"#TestButton"
_button = [UIButton buttonWithType:UIButtonTypeCustom], NI_INVOKE(buttonPress), NILocalizedStringWithDefault(@"TestButton", @"Test Button"), @"#TestButton"

This comment has been minimized.

@jverkoey

jverkoey Feb 22, 2013

Owner

I've been avoiding shortcut macros in Nimbus, leaving that to the application level to define if someone so chooses.

@jverkoey

jverkoey Feb 22, 2013

Owner

I've been avoiding shortcut macros in Nimbus, leaving that to the application level to define if someone so chooses.

Show outdated Hide outdated src/core/src/NITextField.h
@@ -0,0 +1,38 @@
//

This comment has been minimized.

@jverkoey

jverkoey Feb 26, 2013

Owner

This isn't a significant enough feature to merit being in the core. We should create a new feature called "TextInput" for capturing these custom text input fields.

@jverkoey

jverkoey Feb 26, 2013

Owner

This isn't a significant enough feature to merit being in the core. We should create a new feature called "TextInput" for capturing these custom text input fields.

This comment has been minimized.

@djMax

djMax Feb 26, 2013

Any trick to this other than creating the dir? Just seems like a lot of lift for 100 lines given that core has stuff like "NIButtonUtilities", but I understand the other perspective.

@djMax

djMax Feb 26, 2013

Any trick to this other than creating the dir? Just seems like a lot of lift for 100 lines given that core has stuff like "NIButtonUtilities", but I understand the other perspective.

This comment has been minimized.

@jverkoey

jverkoey Feb 26, 2013

Owner

I've generally been trying to avoid adding concrete view subclasses to the
core.

You just have to create a new folder with a src directory containing the
two sources and a feature header.

On Feb 26, 2013, at 11:33 AM, Max Metral notifications@github.com wrote:

In src/core/src/NITextField.h:

@@ -0,0 +1,38 @@
+//

Any trick to this other than creating the dir? Just seems like a lot of
lift for 100 lines given that core has stuff like "NIButtonUtilities", but
I understand the other perspective.


Reply to this email directly or view it on
GitHubhttps://github.com/jverkoey/nimbus/pull/348/files#r3159262
.

@jverkoey

jverkoey Feb 26, 2013

Owner

I've generally been trying to avoid adding concrete view subclasses to the
core.

You just have to create a new folder with a src directory containing the
two sources and a feature header.

On Feb 26, 2013, at 11:33 AM, Max Metral notifications@github.com wrote:

In src/core/src/NITextField.h:

@@ -0,0 +1,38 @@
+//

Any trick to this other than creating the dir? Just seems like a lot of
lift for 100 lines given that core has stuff like "NIButtonUtilities", but
I understand the other perspective.


Reply to this email directly or view it on
GitHubhttps://github.com/jverkoey/nimbus/pull/348/files#r3159262
.

@djMax

This comment has been minimized.

Show comment
Hide comment
@djMax

djMax Feb 27, 2013

Moved it to a feature. I've got support for @media tags coming behind this one too. I can put it in the same pull if you want, else I'll wait until this one is sorted. (This lets you say @media iPad { ...rules...} or @media retina {}, or even @media ipad-retina,iphone-retina {})

djMax commented Feb 27, 2013

Moved it to a feature. I've got support for @media tags coming behind this one too. I can put it in the same pull if you want, else I'll wait until this one is sorted. (This lets you say @media iPad { ...rules...} or @media retina {}, or even @media ipad-retina,iphone-retina {})

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Feb 27, 2013

Owner

Thanks for pulling that out :)

Owner

jverkoey commented Feb 27, 2013

Thanks for pulling that out :)

jverkoey added a commit that referenced this pull request Feb 27, 2013

Merge pull request #348 from djMax/djMaxM_css_nirvana
Minor fixes and feature additions

@jverkoey jverkoey merged commit 53cb2b6 into jverkoey:master Feb 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment