New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't draw cell backgrounds on half pixels on non-retina devices #407

Merged
merged 3 commits into from Jun 6, 2013

Conversation

Projects
None yet
3 participants
@darrenw
Contributor

darrenw commented Jun 5, 2013

On non-retina devices the shadows/border overlapping thing for cell backgrounds is pretty blurry and sticks out near our card-styled (but not drawn using cell backgrounds) views, and also makes it difficult to line our views up and have them look correct - the half-white/half-shadow edge makes the card look bigger than it is. On retina we don't have any such problem though, so half-pixels are ok there.

Provides a minPixelOffset so that people can bail out to the old behaviour if they so choose.

Show outdated Hide outdated src/models/src/NICellBackgrounds.m
@@ -65,15 +65,23 @@ - (id)init {
return self;
}
+ (CGFloat)minPixelOffset {

This comment has been minimized.

@ynie

ynie Jun 5, 2013

Contributor

Could you add some comments here why we need to do this?

@ynie

ynie Jun 5, 2013

Contributor

Could you add some comments here why we need to do this?

@ghost ghost assigned ynie Jun 5, 2013

ynie added a commit that referenced this pull request Jun 6, 2013

Merge pull request #407 from darrenw/NonRetinaCellBackgrounds
Don't draw cell backgrounds on half pixels on non-retina devices

@ynie ynie merged commit 2ceed2c into jverkoey:master Jun 6, 2013

@stephanemoore

This comment has been minimized.

Show comment
Hide comment
@stephanemoore

stephanemoore Jun 6, 2013

Collaborator

I think we should have collapsed these commits into one before merging into master.

Collaborator

stephanemoore commented Jun 6, 2013

I think we should have collapsed these commits into one before merging into master.

@darrenw darrenw deleted the darrenw:NonRetinaCellBackgrounds branch Aug 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment