New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compile time checks to avoid usage of UITextAlignment under iOS 7 SDK and remove duplicated NSLineBreakMode conversion code. #413

Merged
merged 1 commit into from Jul 3, 2013

Conversation

Projects
None yet
2 participants
@liquidx
Contributor

liquidx commented Jul 1, 2013

Defines NIIOS_7_0 and selects usage of NSTextAlignment even when the IPHONE_DEPLOYMENT_TARGET is set to 5.1 or below.

Also removes identical blocks for converting NSLineBreakMode.

Removing usage of UITextAlignment when building against iOS 7 SDK
Remove duplicated blocks when using NSLineBreakMode and define NIIOS_7_0.

@ghost ghost assigned stephanemoore Jul 1, 2013

@stephanemoore

This comment has been minimized.

Show comment
Hide comment
@stephanemoore

stephanemoore Jul 1, 2013

Collaborator

The changes look good to me but I think the commit description might be better phrased like so:
"Update macro conditions to eliminate UITextAlignment references when targeting iOS 7 and eliminate duplicated code for handling line-break modes."

Collaborator

stephanemoore commented Jul 1, 2013

The changes look good to me but I think the commit description might be better phrased like so:
"Update macro conditions to eliminate UITextAlignment references when targeting iOS 7 and eliminate duplicated code for handling line-break modes."

@liquidx

This comment has been minimized.

Show comment
Hide comment
@liquidx

liquidx Jul 2, 2013

Contributor

Thanks for the suggestion, updated the description, although I did add a more detail description in the pull request that I'm not sure whether it gets converted in to a git comment in the end.

Contributor

liquidx commented Jul 2, 2013

Thanks for the suggestion, updated the description, although I did add a more detail description in the pull request that I'm not sure whether it gets converted in to a git comment in the end.

stephanemoore added a commit that referenced this pull request Jul 3, 2013

Merge pull request #413 from liquidx/master
Update compile time checks to avoid usage of UITextAlignment under iOS 7 SDK and remove duplicated NSLineBreakMode conversion code.

@stephanemoore stephanemoore merged commit 19dd716 into jverkoey:master Jul 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment