New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NISegmentedControlFormElementCell layout #482

Merged
merged 1 commit into from Dec 18, 2013

Conversation

Projects
None yet
2 participants
@stephanemoore
Collaborator

stephanemoore commented Dec 17, 2013

Make NISegmentedControlFormElementCell layout take content padding into account.

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Dec 17, 2013

Owner

Can't merge for some reason :(

Owner

jverkoey commented Dec 17, 2013

Can't merge for some reason :(

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Dec 17, 2013

Owner

Also why frame and not bounds? Is the segmented control not a subview of the content view? (Not near a putah to check)

Owner

jverkoey commented Dec 17, 2013

Also why frame and not bounds? Is the segmented control not a subview of the content view? (Not near a putah to check)

@stephanemoore

This comment has been minimized.

Show comment
Hide comment
@stephanemoore

stephanemoore Dec 17, 2013

Collaborator

Rebased the branch back onto master. Hopefully that resolves the merging SNAFU.

This is -[NISegmentedControlFormElementCell layoutSubviews] so self.contentView is a subview. Here is a snippet from the recursive description of an NISegmentedControlFormElementCell:

<NISegmentedControlFormElementCell: 0x10e1bc00; baseClass = UITableViewCell; frame = (0 1234.5; 320 45.5); text = 'Bananas!'; autoresize = W; tag = 12; layer = <CALayer: 0x10e19df0>>
   | <UITableViewCellScrollView: 0x10edd800; frame = (0 0; 320 45.5); clipsToBounds = YES; autoresize = W+H; gestureRecognizers = <NSArray: 0x10ef7b30>; layer = <CALayer: 0x10e937a0>; contentOffset: {0, 0}>
   |    | <UIImageView: 0x10eec160; frame = (0 0; 320 45.5); opaque = NO; userInteractionEnabled = NO; tag = 5; layer = <CALayer: 0x10eebf40>> - (null)
   |    | <UITableViewCellContentView: 0x10e1e9f0; frame = (0 0; 320 45.5); gestureRecognizers = <NSArray: 0x10ef4d30>; layer = <CALayer: 0x10eca280>>
Collaborator

stephanemoore commented Dec 17, 2013

Rebased the branch back onto master. Hopefully that resolves the merging SNAFU.

This is -[NISegmentedControlFormElementCell layoutSubviews] so self.contentView is a subview. Here is a snippet from the recursive description of an NISegmentedControlFormElementCell:

<NISegmentedControlFormElementCell: 0x10e1bc00; baseClass = UITableViewCell; frame = (0 1234.5; 320 45.5); text = 'Bananas!'; autoresize = W; tag = 12; layer = <CALayer: 0x10e19df0>>
   | <UITableViewCellScrollView: 0x10edd800; frame = (0 0; 320 45.5); clipsToBounds = YES; autoresize = W+H; gestureRecognizers = <NSArray: 0x10ef7b30>; layer = <CALayer: 0x10e937a0>; contentOffset: {0, 0}>
   |    | <UIImageView: 0x10eec160; frame = (0 0; 320 45.5); opaque = NO; userInteractionEnabled = NO; tag = 5; layer = <CALayer: 0x10eebf40>> - (null)
   |    | <UITableViewCellContentView: 0x10e1e9f0; frame = (0 0; 320 45.5); gestureRecognizers = <NSArray: 0x10ef4d30>; layer = <CALayer: 0x10eca280>>
@stephanemoore

This comment has been minimized.

Show comment
Hide comment
@stephanemoore

stephanemoore Dec 17, 2013

Collaborator

I may or may not have been mauled by github markdown syntax on that last comment.

Collaborator

stephanemoore commented Dec 17, 2013

I may or may not have been mauled by github markdown syntax on that last comment.

jverkoey added a commit that referenced this pull request Dec 18, 2013

Merge pull request #482 from jverkoey/segmented_control_layout
Fix NISegmentedControlFormElementCell layout

@jverkoey jverkoey merged commit 3a8ac21 into master Dec 18, 2013

@stephanemoore stephanemoore deleted the segmented_control_layout branch Dec 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment