New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tableView delegates when dealloc. #485

Merged
merged 1 commit into from Dec 27, 2013

Conversation

Projects
None yet
2 participants
@dlackty
Contributor

dlackty commented Dec 27, 2013

We recently saw several EXEC_BAD_ACCESS crashes related to UITableView delegates, and resolved those issues by manually setting delegates to nil.

Surprisingly, those UITableView delegates are not weak properties but assign. Ref:

@property (nonatomic, assign)   id <UITableViewDataSource> dataSource;
@property (nonatomic, assign)   id <UITableViewDelegate>   delegate;

jverkoey added a commit that referenced this pull request Dec 27, 2013

Merge pull request #485 from dlackty/dealloc-properly
Remove tableView delegates when dealloc.

@jverkoey jverkoey merged commit 4cc86c6 into jverkoey:master Dec 27, 2013

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Dec 27, 2013

Owner

Thanks!

Owner

jverkoey commented Dec 27, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment