New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the writing direction of the image placeholder string to LTR because image is drawn in LTR manner. #494

Merged
merged 1 commit into from Jan 16, 2014

Conversation

Projects
None yet
2 participants
@muhtasib
Contributor

muhtasib commented Jan 16, 2014

For Right-to-Left text: In drawImages, we obtain the offset, and since the string is RTL, the
offset returned is a RTL offset with the idea the next code will be
drawing in RTL directionality. Whereas the code draws the image in LTR
layout, so I explicitly set the writing direction of the image
placeholder string to LTR (as we draw the image LTR) and thus the
correct offset is returned allowing us to draw LTR and the image is
shown correctly. This shouldn't break LTR clients, as we are just
setting the writing directionality to that.

stephanemoore added a commit that referenced this pull request Jan 16, 2014

Merge pull request #494 from muhtasib/master
Set the writing direction of the image placeholder string to LTR because image is drawn in LTR manner.

@stephanemoore stephanemoore merged commit 66e3451 into jverkoey:master Jan 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment