New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Nimbus 64-bit support #506

Merged
merged 2 commits into from Feb 4, 2014

Conversation

Projects
None yet
3 participants
@stephanemoore
Collaborator

stephanemoore commented Feb 4, 2014

This introduces some changes to facilitate safe CGFloat operations and other 64-bit safety changes.

liquidx added a commit that referenced this pull request Feb 4, 2014

@liquidx liquidx merged commit 4bc56ef into master Feb 4, 2014

*/
#ifdef CGFLOAT_IS_DOUBLE

This comment has been minimized.

@jverkoey

jverkoey Feb 8, 2014

Owner

Aye, this is going to make it always use the CGFLOAT_IS_DOUBLE execution path. I've pushed a change to use #if instead of #ifdef in c8126f8.

@jverkoey

jverkoey Feb 8, 2014

Owner

Aye, this is going to make it always use the CGFLOAT_IS_DOUBLE execution path. I've pushed a change to use #if instead of #ifdef in c8126f8.

This comment has been minimized.

@stephanemoore

stephanemoore Feb 8, 2014

Collaborator

That is egg on my face :S

On Sat, Feb 8, 2014 at 8:11 AM, Jeff Verkoeyen notifications@github.comwrote:

In src/core/src/NIFoundationMethods.h:

@@ -182,6 +182,117 @@

#pragma mark -
+#pragma mark CGFloat Methods
+
+/**

  • * For manipulating CGFloat.
  • * @defgroup CGFloat-Methods CGFloat Methods
  • * @{
  • * These methods provide math functions on CGFloats. They could easily be replaced with <tgmath.h>
  • * but that is currently (Xcode 5.0) incompatible with CLANG_ENABLE_MODULES (on by default for
  • * many projects/targets). We'll use CG_INLINE because this really should be completely inline.
  • */
    +
    +
    +#ifdef CGFLOAT_IS_DOUBLE

Aye, this is going to make it always use the CGFLOAT_IS_DOUBLE execution
path. I've pushed a change to use #if instead of #ifdef in c8126f8c8126f8
.

Reply to this email directly or view it on GitHubhttps://github.com/jverkoey/nimbus/pull/506/files#r9564405
.

@stephanemoore

stephanemoore Feb 8, 2014

Collaborator

That is egg on my face :S

On Sat, Feb 8, 2014 at 8:11 AM, Jeff Verkoeyen notifications@github.comwrote:

In src/core/src/NIFoundationMethods.h:

@@ -182,6 +182,117 @@

#pragma mark -
+#pragma mark CGFloat Methods
+
+/**

  • * For manipulating CGFloat.
  • * @defgroup CGFloat-Methods CGFloat Methods
  • * @{
  • * These methods provide math functions on CGFloats. They could easily be replaced with <tgmath.h>
  • * but that is currently (Xcode 5.0) incompatible with CLANG_ENABLE_MODULES (on by default for
  • * many projects/targets). We'll use CG_INLINE because this really should be completely inline.
  • */
    +
    +
    +#ifdef CGFLOAT_IS_DOUBLE

Aye, this is going to make it always use the CGFLOAT_IS_DOUBLE execution
path. I've pushed a change to use #if instead of #ifdef in c8126f8c8126f8
.

Reply to this email directly or view it on GitHubhttps://github.com/jverkoey/nimbus/pull/506/files#r9564405
.

@jverkoey jverkoey deleted the 64-bit-math branch Feb 8, 2014

@jverkoey

This comment has been minimized.

Show comment
Hide comment
@jverkoey

jverkoey Feb 8, 2014

Owner

Haha no problem, just glad that I noticed the wrong code paths were being greyed out by xcode :p

Owner

jverkoey commented Feb 8, 2014

Haha no problem, just glad that I noticed the wrong code paths were being greyed out by xcode :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment