From 913081649efbec476e52ddeb18086890d6d32804 Mon Sep 17 00:00:00 2001
From: Andrea Odetti <mariofutire@gmail.com>
Date: Sat, 18 Dec 2021 16:43:23 +0000
Subject: [PATCH] Unify exceptions.

Signed-off-by: Andrea Odetti <mariofutire@gmail.com>
---
 source/frontends/libretro/libretro.cpp  |  4 ----
 source/frontends/ncurses/main.cpp       | 10 ----------
 source/linux/duplicates/FourPlay.cpp    |  2 +-
 source/linux/duplicates/SNESMAX.cpp     |  2 +-
 source/linux/duplicates/SerialComms.cpp |  4 ++--
 source/linux/libwindows/winbase.cpp     |  6 +++++-
 source/linux/libwindows/winuser.cpp     |  7 ++++++-
 7 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/source/frontends/libretro/libretro.cpp b/source/frontends/libretro/libretro.cpp
index 365341c4d..e2ea02bf7 100644
--- a/source/frontends/libretro/libretro.cpp
+++ b/source/frontends/libretro/libretro.cpp
@@ -334,10 +334,6 @@ bool retro_load_game(const retro_game_info *info)
   {
     ra2::log_cb(RETRO_LOG_INFO, "Exception: %s\n", e.what());
   }
-  catch (const std::string & s)
-  {
-    ra2::log_cb(RETRO_LOG_INFO, "Exception: %s\n", s.c_str());
-  }
 
   return false;
 }
diff --git a/source/frontends/ncurses/main.cpp b/source/frontends/ncurses/main.cpp
index 51b0b6774..11d2a113b 100644
--- a/source/frontends/ncurses/main.cpp
+++ b/source/frontends/ncurses/main.cpp
@@ -183,14 +183,4 @@ int main(int argc, const char * argv [])
     std::cerr << e.what() << std::endl;
     return 1;
   }
-  catch (const std::string & e)
-  {
-    std::cerr << e << std::endl;
-    return 1;
-  }
-  catch (int e)
-  {
-    std::cerr << "Exit process called: " << e << std::endl;
-    return e;
-  }
 }
diff --git a/source/linux/duplicates/FourPlay.cpp b/source/linux/duplicates/FourPlay.cpp
index 2e2d52e5f..13fbed4e4 100644
--- a/source/linux/duplicates/FourPlay.cpp
+++ b/source/linux/duplicates/FourPlay.cpp
@@ -22,7 +22,7 @@ void FourPlayCard::SaveSnapshot(YamlSaveHelper& yamlSaveHelper)
 bool FourPlayCard::LoadSnapshot(YamlLoadHelper& yamlLoadHelper, UINT version)
 {
 	if (version < 1 || version > kUNIT_VERSION)
-		throw std::string("Card: wrong version");
+		throw std::runtime_error("Card: wrong version");
 
 	return true;
 }
diff --git a/source/linux/duplicates/SNESMAX.cpp b/source/linux/duplicates/SNESMAX.cpp
index 5924bc88f..5487c5872 100644
--- a/source/linux/duplicates/SNESMAX.cpp
+++ b/source/linux/duplicates/SNESMAX.cpp
@@ -24,7 +24,7 @@ void SNESMAXCard::SaveSnapshot(YamlSaveHelper& yamlSaveHelper)
 bool SNESMAXCard::LoadSnapshot(YamlLoadHelper& yamlLoadHelper, UINT version)
 {
 	if (version < 1 || version > kUNIT_VERSION)
-		throw std::string("Card: wrong version");
+		throw std::runtime_error("Card: wrong version");
 
 	return true;
 }
diff --git a/source/linux/duplicates/SerialComms.cpp b/source/linux/duplicates/SerialComms.cpp
index ad32d8dc4..a4681c917 100644
--- a/source/linux/duplicates/SerialComms.cpp
+++ b/source/linux/duplicates/SerialComms.cpp
@@ -57,7 +57,7 @@ static const UINT kUNIT_VERSION = 2;
 void CSuperSerialCard::LoadSnapshotDIPSW(YamlLoadHelper& yamlLoadHelper, std::string key, SSC_DIPSW& dipsw)
 {
   if (!yamlLoadHelper.GetSubMap(key))
-    throw std::string("Card: Expected key: " + key);
+    throw std::runtime_error("Card: Expected key: " + key);
 
   yamlLoadHelper.LoadUint(SS_YAML_KEY_BAUDRATE);
   yamlLoadHelper.LoadUint(SS_YAML_KEY_FWMODE);
@@ -73,7 +73,7 @@ void CSuperSerialCard::LoadSnapshotDIPSW(YamlLoadHelper& yamlLoadHelper, std::st
 bool CSuperSerialCard::LoadSnapshot(YamlLoadHelper& yamlLoadHelper, UINT version)
 {
   if (version < 1 || version > kUNIT_VERSION)
-    throw std::string("Card: wrong version");
+    throw std::runtime_error("Card: wrong version");
 
   SSC_DIPSW dipsw;
   LoadSnapshotDIPSW(yamlLoadHelper, SS_YAML_KEY_DIPSWDEFAULT, dipsw);
diff --git a/source/linux/libwindows/winbase.cpp b/source/linux/libwindows/winbase.cpp
index e05944c7d..fd1883d4a 100644
--- a/source/linux/libwindows/winbase.cpp
+++ b/source/linux/libwindows/winbase.cpp
@@ -5,6 +5,7 @@
 #include <chrono>
 #include <thread>
 #include <unistd.h>
+#include <sstream>
 
 
 DWORD       WINAPI GetLastError(void)
@@ -42,7 +43,10 @@ void OutputDebugString(const char * str)
 
 void ExitProcess(int status)
 {
-  throw status;
+  std::ostringstream buffer("ExitProcess: ");
+  buffer << status;
+
+  throw std::runtime_error(buffer.str());
 }
 
 DWORD       WINAPI WaitForMultipleObjects(DWORD,const HANDLE*,BOOL,DWORD)
diff --git a/source/linux/libwindows/winuser.cpp b/source/linux/libwindows/winuser.cpp
index 92573e7f0..2afad9133 100644
--- a/source/linux/libwindows/winuser.cpp
+++ b/source/linux/libwindows/winuser.cpp
@@ -1,5 +1,7 @@
 #include "winuser.h"
 
+#include <sstream>
+
 HCURSOR LoadCursor(HINSTANCE hInstance, LPCSTR lpCursorName)
 {
   return nullptr;
@@ -32,5 +34,8 @@ LRESULT     WINAPI SendMessage(HWND,UINT,WPARAM,LPARAM)
 
 void        WINAPI PostQuitMessage(INT status)
 {
-  throw status;
+  std::ostringstream buffer("PostQuitMessage: ");
+  buffer << status;
+
+  throw std::runtime_error(buffer.str());
 }