Proper autotool usage in knock #1

merged 1 commit into from Feb 16, 2012


None yet
2 participants

Flameeyes commented Feb 15, 2012

Hi there,

I've looked at the knock ebuild in Gentoo today as i had to use it (and I like to review our init scripts when I can), and I noticed a few issues in the build system.

With this commit you have a proper autotools-based system, using automake as well as autoconf, and I also removed from git the files that are generated and shouldn't be there. To rebuild autotools just run autoreconf -i and it will do.

When you'll release a new version, make distcheck will run some extra tests and also create a tar.xz file for you (you can change dist-xz to dist-bzip2 if you wish).


@Flameeyes Flameeyes Properly autotoolize package.
Use automake rather than hand-tailor a that has a few mistakes
in it.

Make it possible to disable knockd at ./configure time.

Fail if knockd is to be built and libpcap is not found.

Remove all checks that were not used.

Ignore extra files.

@jvinet jvinet added a commit that referenced this pull request Feb 16, 2012

@jvinet jvinet Merge pull request #1 from Flameeyes/master
Proper autotool usage in knock

@jvinet jvinet merged commit 7666f2e into jvinet:master Feb 16, 2012


jvinet commented Feb 16, 2012


@jvinet jvinet pushed a commit that referenced this pull request Dec 9, 2015

@airwoflgh airwoflgh Merge pull request #1 from airwoflgh/airwoflgh-reload_patch_1
Update reload to exit if parseconfig fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment