Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match 0 or 1 usercontent in RawGitHub URL Regular Expression #1

Merged

Conversation

rgbkrk
Copy link

@rgbkrk rgbkrk commented Apr 14, 2014

No description provided.

@rgbkrk rgbkrk changed the title Match 0 or 1 usercontent in RawGitHub regex Match 0 or 1 usercontent in RawGitHub URL Regular Expression Apr 14, 2014
@rgbkrk
Copy link
Author

rgbkrk commented Apr 17, 2014

Only test failure remaining is

$ invoke test
........F.................
======================================================================
FAIL: test_github_blob_redirect (nbviewer.tests.test_github.GitHubTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/kyle6475/code/nbviewer/nbviewer/tests/test_github.py", line 131, in test_github_blob_redirect
    self.assertEqual(r.status_code, 200)
AssertionError: 404 != 200
-------------------- >> begin captured logging << --------------------
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): localhost
requests.packages.urllib3.connectionpool: DEBUG: "GET /github/ipython/ipython/blob/rel-2.0.0/IPython HTTP/1.1" 404 1885
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 26 tests in 20.698s

FAILED (failures=1)

jvns added a commit that referenced this pull request Apr 18, 2014
Match 0 or 1 usercontent in RawGitHub URL Regular Expression
@jvns jvns merged commit ea33606 into jvns:redirect-githubusercontent Apr 18, 2014
@rgbkrk rgbkrk deleted the redirect-githubusercontent branch April 18, 2014 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants