Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support missing values #41

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Support missing values #41

merged 1 commit into from
Feb 16, 2021

Conversation

barche
Copy link
Contributor

@barche barche commented Feb 15, 2021

This adds support for missing values in arrays with units.

Copy link
Owner

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @barche!

@briochemc
Copy link
Collaborator

Thanks! LGTM too! Maybe you can bump the version number in the Project file and then we can merge it and tag a release right away?

@barche
Copy link
Contributor Author

barche commented Feb 16, 2021

OK, done, thanks for the quick reaction!

@codecov-io
Copy link

codecov-io commented Feb 16, 2021

Codecov Report

Merging #41 (b066a28) into master (e80cb4a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files           1        1           
  Lines          77       77           
=======================================
  Hits           64       64           
  Misses         13       13           
Impacted Files Coverage Δ
src/UnitfulRecipes.jl 83.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d94473...b066a28. Read the comment docs.

@jw3126 jw3126 merged commit 4154d53 into jw3126:master Feb 16, 2021
@barche barche deleted the missing branch February 16, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants