From e4a89d470190bdce6182df05096bf58305f88087 Mon Sep 17 00:00:00 2001 From: Jhon Honce Date: Thu, 14 Oct 2021 10:03:26 -0700 Subject: [PATCH] Use CGO_ENABLED=1 when building natively on darwin Need to use CGO for mDNS resolution, but cross builds need CGO disabled See https://github.com/golang/go/issues/12524 for details Note: Homebrew forumla will need to be updated to pick up this change Fixes #10737 Signed-off-by: Jhon Honce --- Makefile | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 7c8c6f1c55fc..22e5c8fa3113 100644 --- a/Makefile +++ b/Makefile @@ -176,6 +176,14 @@ define go-get $(GO) get -u ${1} endef +# Need to use CGO for mDNS resolution, but cross builds need CGO disabled +# See https://github.com/golang/go/issues/12524 for details +ifeq ($(NATIVE_GOOS),darwin) + DARWIN_GCO := 1 +else + DARWIN_GCO := 0 +endif + ### ### Primary entry-point targets ### @@ -351,7 +359,7 @@ podman-remote-windows: ## Build podman-remote for Windows .PHONY: podman-remote-darwin podman-remote-darwin: ## Build podman-remote for macOS $(MAKE) \ - CGO_ENABLED=0 \ + CGO_ENABLED=$(DARWIN_GCO) \ GOOS=darwin \ GOARCH=$(GOARCH) \ bin/darwin/podman