Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@tarsius
Copy link
Contributor

@tarsius tarsius commented Dec 17, 2016

Just because a keymap variable is bound at macro-expansion-time
doesn't mean that it must be bound at run-time too.

Change `bind-keys-form', which is used by `bind-keys' and other
macros, to return a form which delays the decision on whether to
wrap the binding forms with `eval-after-load' until run-time.

Fixes #378.

Just because a keymap variable is bound at macro-expansion-time
doesn't mean that it must be bound at run-time too.

Change `bind-keys-form', which is used by `bind-keys' and other
macros, to return a form which delays the decision on whether to
wrap the binding forms with `eval-after-load' until run-time.

Fixes #378.
@tarsius tarsius changed the title Always use eval-after-load when binding in a map from a package Delay decision whether to use eval-after-load until run-time Dec 18, 2016
@tarsius
Copy link
Contributor Author

tarsius commented Dec 18, 2016

Updated to take #378 (comment) into account.

@jwiegley jwiegley merged commit 901a057 into jwiegley:master Dec 18, 2016
@tarsius tarsius deleted the bind-later branch December 18, 2016 23:30
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Nov 24, 2022
Delay decision whether to use eval-after-load until run-time
GitHub-reference: jwiegley/use-package#419
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this pull request Nov 29, 2022
Delay decision whether to use eval-after-load until run-time
GitHub-reference: jwiegley/use-package#419
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants