usability questions #2

Merged
merged 4 commits into from Mar 7, 2012

Conversation

Projects
None yet
2 participants
Contributor

jinze commented Feb 28, 2012

  1. The CSS files in sets should use image-url helper to include background images.
  2. It is better to use SCSS import feature instead of require other CSS files.
Owner

jwigal commented Mar 5, 2012

I agree with #1.

On #2, does the rails asset pipeline recognize the @import command? I set this up with =require so that the CSS would be included in the pipeline, rather than served up as individual files.

Contributor

jinze commented Mar 6, 2012

"import" is a SASS feature. Considering the user may not using SASS at there project, I revert the README to the old version.

I used to add =require and had no effort because the =require should add at the top of the js file.

@jwigal jwigal merged commit 6794e63 into jwigal:master Mar 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment