New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with networks (supports new overlay network) #153

Merged
merged 1 commit into from Jan 26, 2016

Conversation

Projects
None yet
2 participants
@baptistedonaux
Contributor

baptistedonaux commented Jan 15, 2016

Initial template works with current model network.

If you use the new overlay network (ex. docker-compose --x-networking up), the golang structure RuntimeContainer -> []Address doesn't contain IP (empty string).

Use []Network array resolved the problem.

@jwilder

This comment has been minimized.

Owner

jwilder commented Jan 15, 2016

This file is just an example. Were you intending to fix this issue w/ nginx-proxy?

@baptistedonaux

This comment has been minimized.

Contributor

baptistedonaux commented Jan 17, 2016

I send PR on jwilder/nginx-proxy.

But I think that fix template example right now will limit the feedback, because the new model network will be activate systematically in the docker-compose next release. For docker-compose 1.6, the containers IP will be set in []Network and not more in []Address.

jwilder added a commit that referenced this pull request Jan 26, 2016

Merge pull request #153 from baptistedonaux/master
Deal with networks (supports new overlay network)

@jwilder jwilder merged commit 9bfce75 into jwilder:master Jan 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jwilder

This comment has been minimized.

Owner

jwilder commented Jan 26, 2016

Thanks @baptistedonaux!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment