Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors for WinPTY #2344

Open
chrisduerr opened this issue Apr 21, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@chrisduerr
Copy link
Collaborator

commented Apr 21, 2019

In the #2261 PR the ConPTY errors have been improved to make it obvious why a shell could not be started. However, the WinPTY messages are unchanged and there currently is no output at all when spawning the WinPTY failed.

It should be made clear to the user that the shell could not be found when starting Alacritty with an invalid shell.

Based on the little research I've done, it seems like there's no place in Alacritty to catch this error and it's swallowed further down in the WinPTY dependency chain. Maybe @zacps knows something about this, but I'd assume that we might have to fix something in the winpty-sys crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.