New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SRGB (fix #921) #1178

Merged
merged 1 commit into from Mar 13, 2018

Conversation

Projects
None yet
3 participants
@lo48576
Copy link
Contributor

lo48576 commented Mar 12, 2018

This fixes #921, the error Error creating GL context; Couldn't find any pixel format that matches the criterias..

I'm not sure whether this is right and ideal solution, but this change actually fix the issue for some people including me.

Enable SRGB
This will solve the error "Error creating GL context; Couldn't find any
pixel format that matches the criterias."

(I think this maybe a problem of mesa (18.0.0_rc4), but I'm not sure.

See the thread <https://mastodon.cardina1.red/@lo48576/99670278063669603>
for my debug log.
@chrisduerr

This comment has been minimized.

Copy link
Collaborator

chrisduerr commented Mar 12, 2018

Might be interesting to see how this works on MacOS. Even without the issue present it seems to work fine on my linux machine.

@jwilm

jwilm approved these changes Mar 13, 2018

Copy link
Owner

jwilm left a comment

Thanks for figuring this out and sending a patch! Works fine on macOS as well.

@jwilm jwilm merged commit 5dad491 into jwilm:master Mar 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lo48576 added a commit to lo48576/alacritty that referenced this pull request Mar 13, 2018

lo48576 added a commit to lo48576/alacritty that referenced this pull request Mar 13, 2018

jwilm added a commit that referenced this pull request Mar 13, 2018

Try to create window with different SRGB config when failed
This may truly solve #921 (and issue caused by #1178)
<#921 (comment)>.

@lo48576 lo48576 deleted the lo48576:fix/mesa-32bit-transparent branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment