Update for the new world order. #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add pry as a development dependency so it can be used for bundle console.
The way that yield was being used in a Celluloid actor is apparently no longer allowed. Update to convert the block provided to pmap into a proc object to work with Celluloid.
The custom :take_approximately RSpec matcher defined in benchmark_spec.rb was not working correctly. Add supports_block_expectations and correct variable names in it so that it works with RSpec.
|
AWESOME @jvoegele I'll look at this and get merged in asap |
|
I've got another Pull Request coming up, but it depends on this one so I'll wait until you've had a chance to review and merge this one before submitting the next. |
|
Hi jwo, any chance you'll be able to take a look at this and (hopefully) merge soon? |
|
@jvoegele Just checked it out, thanks for the ping. Thanks for this, super awesome! I believe you had a couple other changes, right? I'll get to those sooner and we can release the gem up to rubygems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to update to the latest version of Celluloid (explicitly) and RSpec (implicitly). This requires some changes to the code, details of which are provided in the individual commit messages.