New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for the new world order. #3

Merged
merged 3 commits into from Feb 19, 2015

Conversation

Projects
None yet
2 participants
@jvoegele
Contributor

jvoegele commented Feb 13, 2015

This is to update to the latest version of Celluloid (explicitly) and RSpec (implicitly). This requires some changes to the code, details of which are provided in the individual commit messages.

jvoegele added some commits Feb 13, 2015

Update Celluloid dependency version.
Also, add pry as a development dependency so it can be used for bundle
console.
Update to work with latest Celluloid version.
The way that yield was being used in a Celluloid actor is apparently no
longer allowed. Update to convert the block provided to pmap into a proc
object to work with Celluloid.
Fix custom RSpec matcher.
The custom :take_approximately RSpec matcher defined in
benchmark_spec.rb was not working correctly. Add
supports_block_expectations and correct variable names in it so that it
works with RSpec.
@jwo

This comment has been minimized.

Show comment
Hide comment
@jwo

jwo Feb 13, 2015

Owner

AWESOME @jvoegele I'll look at this and get merged in asap

Owner

jwo commented Feb 13, 2015

AWESOME @jvoegele I'll look at this and get merged in asap

@jvoegele

This comment has been minimized.

Show comment
Hide comment
@jvoegele

jvoegele Feb 13, 2015

Contributor

I've got another Pull Request coming up, but it depends on this one so I'll wait until you've had a chance to review and merge this one before submitting the next.

Contributor

jvoegele commented Feb 13, 2015

I've got another Pull Request coming up, but it depends on this one so I'll wait until you've had a chance to review and merge this one before submitting the next.

@jvoegele

This comment has been minimized.

Show comment
Hide comment
@jvoegele

jvoegele Feb 19, 2015

Contributor

Hi jwo, any chance you'll be able to take a look at this and (hopefully) merge soon?

Contributor

jvoegele commented Feb 19, 2015

Hi jwo, any chance you'll be able to take a look at this and (hopefully) merge soon?

@jwo jwo merged commit a5fa1c4 into jwo:master Feb 19, 2015

@jwo

This comment has been minimized.

Show comment
Hide comment
@jwo

jwo Feb 19, 2015

Owner

@jvoegele Just checked it out, thanks for the ping.

Thanks for this, super awesome!

I believe you had a couple other changes, right? I'll get to those sooner and we can release the gem up to rubygems.

Owner

jwo commented Feb 19, 2015

@jvoegele Just checked it out, thanks for the ping.

Thanks for this, super awesome!

I believe you had a couple other changes, right? I'll get to those sooner and we can release the gem up to rubygems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment