[JW8-6113] Implement progressive AES decryption #219
Conversation
Breaking change: force software AES decrypter if config is true
|
|
|
test this please |
|
|
|
|
|
|
|
|
{{ message }}
Merged
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetagame
reviewed
Jun 18, 2019
robwalch
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Implement progressive software AES decryption
TypeScript decryption classes
Breaking changes:
enableSoftwareAESis trueenableSoftwareAESto true if using the progressive Fetch loaderWhy is this Pull Request needed?
So that we can progressively parse AES-128 encrypted streams
Are there any points in the code the reviewer needs to double check?
Is the removal of the
destroymethod from the software decrypter OK? I don't believe it's necessary to set those members to null when the reference to the decrypter itself is set to null. Nulling that reference should cause its members to be GC'dResolves issues:
JW8-6113