Workaround for Android 'inert-visual-viewport' behavior #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works pretty well for dragging. Can we expand this solution to also work when tapping on the time slider? |
not intended for all viewport settings where horizontal scrolling without zooming the viewport can occur JW7-1078
robwalch
force-pushed
the
bugfix/android-slider-viewport-zoomed
branch
from
15b42ea
to
b25b6dc
Compare
|
Thx @jw-kaurand. Fixed it. |
jw-kaurand
approved these changes
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is limited to horizontal sliders on Android where pageXOffset is not 0 - assuming this means the viewport is offset from zooming and not scrolling the page. It's not intended for all viewport settings where horizontal scrolling without zooming the viewport can occur. Most pages only scroll vertically at 100% (not zoomed), and only scroll horizontally when zoomed in so this should help compatibility with 'inert-visual-viewport' behavior.
JW7-1078