New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docs #1654

Merged
merged 18 commits into from Jan 5, 2017

Conversation

Projects
None yet
4 participants
@johnBartos
Member

johnBartos commented Dec 29, 2016

  • Create CONTRIBUTING.md
  • Update README.md

Style inspired by Hoodie's Awesome Docs

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Dec 29, 2016

Automated tests passed!

Cheers! 🍻 👐

BUILDING.md Outdated
git remote add upstream https://github.com/jwplayer/jwplayer
````
2. Install the dependencies:

This comment has been minimized.

@egreaves

egreaves Dec 30, 2016

Member

In the markup, the numbering isn't incremented for each item.

This comment has been minimized.

@robwalch

robwalch Jan 4, 2017

Member

@johnBartos removing the line breaks should fix that. Line numbers reset to 1 in md after a line break.

johnBartos added some commits Jan 4, 2017

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Jan 5, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

robwalch added some commits Jan 5, 2017

README.md Outdated
## A Simple Example
The example below and render a video player into the div with the `player` id, listens to an event, and makes a few calls using the API.

This comment has been minimized.

@robwalch

robwalch Jan 5, 2017

Member

The example below and render a video player...

I don't quite understand this sentence.

If you've never contributed before, don't worry - we'll do the best we can to help you throughout the process. Unsure of where to begin? Check out our [beginner bugs](https://github.com/jwplayer/jwplayer/labels/beginner), or refer to the Questions/Discussions section and drop us a line.
#### General Guidelines
While far from comprehensive, following these guidelines will get the easy stuff out of the way and speed the process along. Be sure to include a good

This comment has been minimized.

@robwalch

robwalch Jan 5, 2017

Member

Be sure to include a good

a good what?

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Jan 5, 2017

Caution when merging! Automated tests either failed or had an error. Please confirm stable build before merging. ab4a21b

Get some ☕️

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Jan 5, 2017

Caution when merging! Automated tests either failed or had an error. Please confirm stable build before merging. efa7d64

Get some ☕️

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Jan 5, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Jan 5, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Jan 5, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

@robwalch robwalch merged commit c5b14ef into master Jan 5, 2017

2 of 3 checks passed

default Build started sha1 is merged.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@robwalch robwalch removed the needs-review label Jan 5, 2017

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Jan 5, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

pajong added a commit that referenced this pull request Jan 6, 2017

Merge remote-tracking branch 'origin/master' into feature/remove-atta…
…ch-detach

* origin/master: (42 commits)
  Update package.json repository
  Make background color override gradient in config match default CSS
  Improve time slider above gradient on white video frames
  Fix README formatting
  Bringing back a style to position menu overlays when jw-flag-time-slider-above is active
  Show control bar on vpaid if vpaid-controls is set
  Running `grunt karma:browserstack` will run tests on Chrome, Firefox and IE11
  Work around exceptions thrown in intersection-observer polyfill when run in IE9-11
  Integrating Mobile UI and Casting
  New docs (#1654)
  Adds some comments and ensures auto height
  Align time/cuepoint tooltip in timeSliderAbove mode
  More cast icon cleanup
  Switching from px to em
  Update cast icon
  Display replay icon in controlbar in complete state
  Move background gradient to control bar element
  Enable small player color override styles
  Resume flash streams after cast disconnection
  PR change
  ...

@robwalch robwalch deleted the feature/update-docs branch Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment