New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timeslider UI and controlbar background #2246

Merged
merged 11 commits into from Aug 21, 2017

Conversation

Projects
None yet
4 participants
@radium-v
Contributor

radium-v commented Aug 17, 2017

This PR will...

Make the controlbar and timeslider look all cool and stuff

Are there any points in the code the reviewer needs to double check?

  • Addresses Strict Math (Fixes #2189) See http://lesscss.org/usage/#command-line-usage-strict-math
  • These visual adjustments differ from the design spec documents and have been approved by the Design Team:
    • The time/thumbnail/cue tooltip arrow has been flipped to be more like a traditional tooltip.
    • The controls background gradient has been extended and softened to blend better on bright.
  • Animations/transitions on the timeslider may not be relevant on devices without a dedicated hover state.

Addresses Issue(s):

JW8-95
JW8-283

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Aug 17, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

@egreaves egreaves self-assigned this Aug 18, 2017

@robwalch

This comment has been minimized.

Member

robwalch commented Aug 18, 2017

If you write "Fixes #2189" in the description, merging this PR will close that ticket.

@egreaves

@radium-v let's address focus/hover/active states for player elements in this.

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Aug 18, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

@jwplayer jwplayer deleted a comment from karimMourra Aug 21, 2017

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Aug 21, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

@jwplayer jwplayer deleted a comment from jwplayer-robot Aug 21, 2017

@egreaves

This comment has been minimized.

Member

egreaves commented Aug 21, 2017

Noticed a few things:

  • Buffer icon needs improvement
  • Active state isn't being set for the settings menu (@johnBartos to ensure class is added in #2250)
  • Live duration text needs to be evenly spaced (addressed in #2234)

@egreaves egreaves merged commit af6fb77 into master Aug 21, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jw7-pr-builder-opensource Build finished.
Details

@egreaves egreaves removed the needs-review label Aug 21, 2017

@robwalch robwalch deleted the improvement/timeslider-hover-styles branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment