New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook: Run Karma Locally #2284

Merged
merged 3 commits into from Aug 29, 2017

Conversation

Projects
None yet
4 participants
@hghazzi
Contributor

hghazzi commented Aug 28, 2017

This PR will...

run karma via a npm script

Why is this Pull Request needed?

otherwise, it will try to run it with the global karma which may not always be installed

Are there any points in the code the reviewer needs to double check?

rerun git hooks

Are there any Pull Requests open in other repos which need to be merged with this?

same thing for commercial

https://github.com/jwplayer/jwplayer-commercial/pull/3970

hghazzi added some commits Aug 27, 2017

@hghazzi hghazzi added this to the v8.0.0 milestone Aug 28, 2017

@hghazzi hghazzi changed the title from Tech debt/prepush fix to Hook: Run Karma Locally Aug 28, 2017

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Aug 28, 2017

Automated tests passed!

Cheers! 🥃 👐 🌮

@johnBartos johnBartos merged commit d7c692a into master Aug 29, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jw7-pr-builder-opensource Build finished.
Details

@hghazzi hghazzi deleted the tech-debt/prepush-fix branch Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment