Youtube HTML5 autoplay fix [Finishes #86721652] #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et up. If it isn't then we queue up a play call once the player is ready. This issue is caused by attempting to play when the provider hasn't finished setting up, so we will just play once its finished setting up.
jw-kaurand
changed the title
…already has been assigned so we don't overwrite it with the onStart value. Now callbacks are called in the order in which they were set. Compose function was used from underscore and only added in this class as its the only place where we currently need it.
donato
added a commit
that referenced
this pull request
Feb 4, 2015
Youtube HTML5 autoplay fix [Delivers #86721652]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue noted in #86721652 by checking if _youtubePlayer is set up. If it isn't then we queue up a play call once the player is ready. This issue is caused by attempting to play when the provider hasn't finished setting up, so we will just play once its finished setting up. [Finishes #86721652]