New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DangerJS #2736

Merged
merged 9 commits into from Feb 22, 2018

Conversation

Projects
None yet
3 participants
@johnBartos
Member

johnBartos commented Feb 22, 2018

Why is this Pull Request needed?

To enforce code standards & culture with automated (and friendly) warnings.
http://danger.systems/js/

Currently, this bot will warn you if:

  • You didn't assign any reviewers or assignees
  • You didn't assign a milestone
  • You didn't write new tests after touching source code
  • You added a package with a non-exact version (error)

Danger won't fail your build right now; these warnings are meant to be reminders. The purpose of this bot is to reduce the amount of policing needed during the PR phase (and some may not feel comfortable nitpicking); and to increase the quality of the code landing in a PR. The hopeful result is that all work going into the Player continues to uphold the quality of code we expect, with a quicker and less painful PR process.

johnBartos added some commits Feb 22, 2018

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Feb 22, 2018

Build for commit 63188d4 passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@robwalch

This comment has been minimized.

Member

robwalch commented Feb 22, 2018

Warnings
⚠️

🗿 Set a milestone. It should be the ticket's fix version in JIRA.

Generated by 🚫 dangerJS

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Feb 22, 2018

Build for commit e8eec36 passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Feb 22, 2018

Build for commit 8deb08d passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Feb 22, 2018

Build for commit 7b5ea6a passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Feb 22, 2018

Build for commit 4818aa9 passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@johnBartos johnBartos merged commit 7e50240 into master Feb 22, 2018

4 checks passed

Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jw7-pr-builder-opensource Build finished.
Details

@robwalch robwalch deleted the feature/danger branch May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment