New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license banner to JS build output #2759

Merged
merged 6 commits into from Mar 6, 2018

Conversation

Projects
None yet
5 participants
@robwalch
Member

robwalch commented Mar 3, 2018

This PR will...

  • Include open-source license attribution at the top of all JS files in build
    • Also output to notice.txt in bin-release folder
  • Cleanup attribution comments in source code
  • Import promise-polyfill@v7.1.0 from node_modules

The license comment and notice.txt matches what we will output for the commercial player. In this project the notice.txt is not hosted by us with each release so it's included in the JS output. This version of the notice only includes references to projects used in this project.

These changes update open-source attribution in our source to reference the specific versions we use and include comment banners from original source.

The Promise polyfill is now imported from source in our dev dependencies so that it can be maintained through a package manager (yarn/npm) and minified as part of the project's build.

Addresses Issue(s):

JW8-1235

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Mar 3, 2018

Build for commit e7e001a passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@robwalch robwalch added this to the v8.2.0 milestone Mar 3, 2018

@jwplayer jwplayer deleted a comment from johnBartos Mar 3, 2018

@johnBartos

This comment has been minimized.

Member

johnBartos commented Mar 3, 2018

Warnings
⚠️

🛠 There are modified src files, but no test changes. Add tests if you're able to.

Generated by 🚫 dangerJS

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Mar 3, 2018

Build for commit 2fb2655 passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

robwalch added some commits Mar 5, 2018

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Mar 5, 2018

Build for commit 410e93c failed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests UNSTABLE
🍆 Manual Tests
📺 Views

@robwalch robwalch changed the title from Cleanup source attribution comments to Add license banner to JS build output Mar 6, 2018

@jwplayer jwplayer deleted a comment from jwplayer-robot Mar 6, 2018

@johnBartos johnBartos merged commit 5d3360f into master Mar 6, 2018

3 of 4 checks passed

jw7-pr-builder-opensource Build started sha1 is merged.
Details
Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@johnBartos johnBartos removed the needs-review label Mar 6, 2018

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Mar 6, 2018

Build for commit 387d5df passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@robwalch robwalch deleted the feature/attribute-source branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment