New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add framework integration table & add micnews react library #3059

Merged
merged 3 commits into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@johnBartos
Member

johnBartos commented Sep 10, 2018

Why is this Pull Request needed?

So that developers who want to use JW with React can take advantage of a well-maintained library. Future libraries can be added to the table.

I asked permission and they're cool with us linking it: micnews/react-jw-player#109

Are there any points in the code the reviewer needs to double check?

Wording

Are there any Pull Requests open in other repos which need to be merged with this?

No

@johnBartos johnBartos requested review from egreaves and esboyd Sep 10, 2018

@johnBartos

This comment has been minimized.

Member

johnBartos commented Sep 10, 2018

Warnings
⚠️

🗿 Set a milestone. It should be the ticket's fix version in JIRA.

Generated by 🚫 dangerJS

@jwplayer jwplayer deleted a comment from jwplayer-robot Oct 1, 2018

@jwplayer jwplayer deleted a comment from jwplayer-robot Oct 9, 2018

@jwplayer jwplayer deleted a comment from jwplayer-robot Oct 9, 2018

@jwplayer jwplayer deleted a comment from jwplayer-robot Oct 9, 2018

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Oct 9, 2018

❗️ MULTI Build for commit 2c2420e did not complete.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests UNSTABLE
🍆 Manual Tests
📺 Views

@johnBartos johnBartos merged commit 424a5f6 into master Nov 9, 2018

3 of 4 checks passed

jw7-pr-multi-opensource Build finished.
Details
Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment