New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure playback label is centered in IE #3172

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
4 participants
@boyntoni
Contributor

boyntoni commented Nov 7, 2018

This PR will...

Add left and transform properties to the .jw-idle-icon-textclass to center the text in Internet Explorer.

Why is this Pull Request needed?

(Seemingly) a bug in IE was preventing Flexbox from working its magic.

Are there any points in the code the reviewer needs to double check?

No.

Are there any Pull Requests open in other repos which need to be merged with this?

No.

Addresses Issue(s):

JW8-2360

@boyntoni boyntoni requested review from radium-v and DanFerrer Nov 7, 2018

@johnBartos

This comment has been minimized.

Member

johnBartos commented Nov 7, 2018

Warnings
⚠️

🛠 There are modified src files, but no test changes. Add tests if you're able to.

⚠️

🗿 Set a milestone. It should be the ticket's fix version in JIRA.

Generated by 🚫 dangerJS

@jwplayer-robot

This comment has been minimized.

jwplayer-robot commented Nov 7, 2018

MULTI Build for commit 8ac1f56 passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@radium-v radium-v added this to the 8.6.3 milestone Nov 8, 2018

@radium-v radium-v merged commit 701da2a into master Nov 8, 2018

4 checks passed

Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jw7-pr-multi-opensource Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment