New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary aria-expanded #3245

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@karimMourra
Copy link
Contributor

karimMourra commented Jan 10, 2019

This PR will...

  • remove aria-expanded from the tooltips

Why is this Pull Request needed?

Per the documentation, aria-expanded should be used on elements which can be interacted with to expand or collapse content (i.e. a drop down list). This label is unnecessary for tooltips since they cannot be interacted with; the user can't tab into a tooltip. The tooltip's purpose is to display information; the same information is contained by the aria-labels on the actual buttons, and is announced by the screen reader.

Are there any points in the code the reviewer needs to double check?

n/a

Are there any Pull Requests open in other repos which need to be merged with this?

jwplayer/jwplayer-plugin-related#370

Addresses Issue(s):

JW8-2518

@karimMourra karimMourra requested review from robwalch and DanFerrer Jan 10, 2019

@karimMourra karimMourra added this to the 8.7.4 milestone Jan 10, 2019

@johnBartos

This comment has been minimized.

Copy link
Member

johnBartos commented Jan 10, 2019

Warnings
⚠️

🛠 There are modified src files, but no test changes. Add tests if you're able to.

Generated by 🚫 dangerJS

@jwplayer-robot

This comment has been minimized.

Copy link

jwplayer-robot commented Jan 11, 2019

MULTI Build for commit 4ddab3d passed.
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@robwalch robwalch merged commit 296d0b0 into master Jan 11, 2019

4 checks passed

Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jw7-pr-multi-opensource Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment