Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JW8-2319] Update to webpack 4.29 and babel 7 #3275

Merged
merged 2 commits into from Feb 1, 2019

Conversation

@robwalch
Copy link
Contributor

@robwalch robwalch commented Feb 1, 2019

This PR will...

  • Update to webpack 4.29 and babel 7
  • ES6 output compatibility (babel loader must be disabled)
    • Make Events and SimpleModel base classes
    • Fix webvtt.js var scoping
  • Remove use of side-effects on module imports in tests (karma-webpack no longer converts modules to common-js)
  • Update browserslist to match minimum browser version dependencies
  • Move src/templates into src/js/templates (.js modules should all be resolved in src/js)
  • Removed unused dependencies (file-loader, raw-loader, url-loader, loader-utils, autoprefixer, source-map)

Why is this Pull Request needed?

To improve build output and dependency maintenance.

Are there any Pull Requests open in other repos which need to be merged with this?

jwplayer/jwplayer-commercial#6262
jwplayer/jwplayer-plugin-related#372

Addresses Issue(s):

JW8-2319

- Remove use of side-effects on module imports in tests
- Make Events and SimpleModel base classes for ES6 output compatibility
JW8-2319
@robwalch robwalch added this to the 8.8.0 milestone Feb 1, 2019
@robwalch robwalch requested review from radium-v, johnBartos and DanFerrer Feb 1, 2019
@jwplayer-robot
Copy link

@jwplayer-robot jwplayer-robot commented Feb 1, 2019

MULTI Build for commit a1bd919 did not complete (FAILURE).
🏗️ jwplayer build SUCCESS
🏗️ jwplayer browserstack tests SUCCESS
🏗️ jwplayer-commercial build SUCCESS
🏗️ jwplayer-commercial browserstack tests FAILURE (related branch not matched)
🍆 Manual Tests
📺 Views

@jwplayer-robot
Copy link

@jwplayer-robot jwplayer-robot commented Feb 1, 2019

MULTI Build for commit a1bd919 passed.
🏗️ jwplayer build SUCCESS
🏗️ jwplayer browserstack tests SUCCESS
🏗️ jwplayer-commercial build SUCCESS
🏗️ jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@robwalch robwalch changed the title Update to webpack 4.29 and babel 7 [JW8-2319] Update to webpack 4.29 and babel 7 Feb 1, 2019
src/js/utils/backbone.events.js Outdated Show resolved Hide resolved
@jwplayer-robot
Copy link

@jwplayer-robot jwplayer-robot commented Feb 1, 2019

MULTI Build for commit f2c54a0 passed.
🏗️ jwplayer build SUCCESS
🏗️ jwplayer browserstack tests SUCCESS
🏗️ jwplayer-commercial build SUCCESS
🏗️ jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests SUCCESS
🍆 Manual Tests
📺 Views

@johnBartos johnBartos merged commit 24bfb49 into master Feb 1, 2019
4 checks passed
4 checks passed
@johnBartos
Danger All green. Jolly good show.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jwplayer-robot
jw7-pr-multi-opensource Build finished.
Details
pajong added a commit that referenced this pull request Feb 13, 2019
…ostart-unmuted

* origin/master:
  Return in interactEndHandler when retriggered during destroy in IE
  Return window if element is null or undefined
  Return in getElementWindow() if element is null
  Simplify model.add method
  Rename internal 'floating' model variable
  Update float config option to floating
  apply changes to showSettingsMenu function
  check for playbackrates
  move settings menu display logic into function
  only show settings menu icon if there is a submenu JW8-2159
  Fix regression from floatin changes
  [JW8-2319] Update to webpack 4.29 and babel 7 (#3275)
  Change floatOnScroll boolean to float object (#3262)
  update test dependencies
@robwalch robwalch deleted the task/update-webpack-4-babel-7 branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants