[JW8-5629] Capture pointer on drag #3323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Call
setPointerCapture
to ui elements withpreventScrolling
options when dragging starts, instead of onpointerdown
Why is this Pull Request needed?
preventScrolling
option on desktop callsel.setPointerCapture
, resulting the upcoming events to be only captured in that element.Since
_wrapperElement
is the element (which contains controls), any events afterpointerdown
on controls that are forwarded to_wrapperElement
are ignored, making the controls not clickable.Since the goal of the
preventScrolling
option was to prevent scroll (not clicks), capture pointer should happen when we start dragging.Are there any points in the code the reviewer needs to double check?
Are there any Pull Requests open in other repos which need to be merged with this?
Addresses Issue(s):
JW8-5643