Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JW8-5629] Capture pointer on drag #3323

Merged
merged 2 commits into from Mar 11, 2019

Conversation

pajong
Copy link
Contributor

@pajong pajong commented Mar 11, 2019

This PR will...

Call setPointerCapture to ui elements with preventScrolling options when dragging starts, instead of on pointerdown

Why is this Pull Request needed?

preventScrolling option on desktop calls el.setPointerCapture, resulting the upcoming events to be only captured in that element.
Since _wrapperElement is the element (which contains controls), any events after pointerdown on controls that are forwarded to _wrapperElement are ignored, making the controls not clickable.

Since the goal of the preventScrolling option was to prevent scroll (not clicks), capture pointer should happen when we start dragging.

Are there any points in the code the reviewer needs to double check?

Are there any Pull Requests open in other repos which need to be merged with this?

Addresses Issue(s):

JW8-5643

@johnBartos
Copy link
Contributor

johnBartos commented Mar 11, 2019

Warnings
⚠️

🗿 Set a milestone. It should be the ticket's fix version in JIRA.

Generated by 🚫 dangerJS

@jwplayer-robot
Copy link

MULTI Build for commit 825edd2 did not complete (FAILURE).
🏗️ jwplayer build FAILURE
🏗️ jwplayer browserstack tests ${JW7_OPENSOURCE_UNIT_TESTS_BUILD_RESULT}
🏗️ jwplayer-commercial build ${JW7_COMMERCIAL_BUILD_RESULT}
🏗️ jwplayer-commercial browserstack tests ${JW7_COMMERCIAL_UNIT_TESTS_BUILD_RESULT}
🥒 Automated Tests ${JW7_COMMERCIAL_CUCUMBER_BUILD_RESULT}
🍆 Manual Tests
📺 Views

@pajong pajong requested a review from robwalch March 11, 2019 18:49
@robwalch robwalch added this to the 8.8.0 milestone Mar 11, 2019
@robwalch robwalch merged commit ac5c60a into master Mar 11, 2019
@robwalch robwalch changed the title Capture pointer on drag [JW8-5629] Capture pointer on drag Mar 11, 2019
@jwplayer-robot
Copy link

⚠️ MULTI Build for commit 628115d is unstable (UNSTABLE).
🏗️ jwplayer build SUCCESS
🏗️ jwplayer browserstack tests SUCCESS
🏗️ jwplayer-commercial build SUCCESS
🏗️ jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests UNSTABLE
🍆 Manual Tests
📺 Views

@robwalch robwalch deleted the wip/ui-pointer-capture-when-dragging branch June 25, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants