Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nextup HTML parsing regression #3411

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
5 participants
@robwalch
Copy link
Member

commented May 15, 2019

Fixes HTML encoded characters in localization showing up in nextup header instead of being parsed

https://jenkins.jwplayer.com/view/JW7/job/jw7-commercial-cucumber/17352/allure/#suites/2e601b5804091b68ac974d7394ebdefd/651bf599d7b85e3c/

The header on the nextup tooltip should read Next' not Next'.
image

Test config

{
    autostart: true,
    events: {
        firstFrame: function() {
            this.pause();
            this.seek(this.getDuration() - 5);
            this.setMute(false);
        }
    },
  "playlist": [
    {
      "file": "//playertest.longtailvideo.com/adaptive/paradise/paradise-novtt.m3u8",
      "title": "Paradise ©",
      "description": "Description of video £"
    },
    {
      "file": "//playertest.longtailvideo.com/adaptive/paradise/paradise-novtt.m3u8",
      "title": "Paradise &amp; & << double ampersand (HTML entity and ASCII) ",
      "description": "Description of video &euro;"
    }
  ],
  "displayPlaybackLabel": true,
  "localization": {
    "playback": "&yen;WOW&yen;",
    "auto": "Automatico&apos;",
    "logo": "Logo_Test&apos;",
    "off": "Desactivado&apos;",
    "related": "MoreVideos&apos;",
    "nextUp": "Next&apos;",
    "hd": "Calidad&apos;",
    "settings": "Ajustes&apos;",
    "fullscreen": "Pantalla_completa&apos;",
    "airplay": "AirPlay_Test&apos;",
    "audioTracks": "AT_Test&apos;",
    "rewind": "Rebobinar&apos;",
    "buffer": "Loading Test&apos;",
    "cast": "Cast_Test&apos;",
    "cc": "CC_Test&apos;",
    "poweredBy": "Potenciado por&apos;",
    "slider": "Barra&apos;",
    "mute": "Mute_Test&apos;",
    "unmute": "Unmute_Test&apos;",
    "sharing": {
      "email": "Correo&apos;",
      "embed": "Embebido&apos;",
      "link": "Vinculo&apos;",
      "heading": "Compartir&apos;"
    },
    "videoInfo": "Acerca de este video&apos;",
    "volumeSlider": "Volumen&apos;",
    "volume": "Volume_Test&apos;",
    "replay": "Repetir&apos;"
  },
  "related": {
    "file": "http://content.jwplatform.com/v2/playlists/okVLNIks?related_media_id=sYKZyjxB"
  }
}

Noticed the issue while reviewing a PR test failure in this PR jwplayer/jwplayer-commercial#6647

@robwalch robwalch added this to the 8.9.0 milestone May 15, 2019

@robwalch robwalch requested review from aizaztoppa and jnatalzia May 15, 2019

@johnBartos

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Warnings
⚠️

🛠 There are modified src files, but no test changes. Add tests if you're able to.

Generated by 🚫 dangerJS

@jwplayer-robot

This comment has been minimized.

Copy link

commented May 15, 2019

⚠️ MULTI Build for commit 6cc3423 is unstable (UNSTABLE).
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests UNSTABLE
🍆 Manual Tests
📺 Views

@jnatalzia
Copy link
Collaborator

left a comment

huh. unfortunate that there isn't a decodeURIComponent for html entities. either way looks great!

@aizaztoppa
Copy link

left a comment

@robwalch Thanks, looks like Cesar logged a ticket for this 2 days ago - https://jwplayer.atlassian.net/browse/JW8-9109

@robwalch robwalch merged commit 16fcfd2 into master May 16, 2019

3 of 4 checks passed

jw7-pr-multi-opensource Build finished.
Details
Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.