Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement latency getter in default provider, mixin #3432

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@johnBartos
Copy link
Member

commented Jun 10, 2019

This PR will...

Call getLiveLatency on the timeupdate video event

Why is this Pull Request needed?

So that we can ping live latency for A/B testing

Are there any points in the code the reviewer needs to double check?

No

Are there any Pull Requests open in other repos which need to be merged with this?

jwplayer/jwplayer-commercial#6747

Addresses Issue(s):

JW8-9325

@johnBartos johnBartos requested a review from robwalch as a code owner Jun 10, 2019

@johnBartos

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Warnings
⚠️

🛠 There are modified src files, but no test changes. Add tests if you're able to.

⚠️

🗿 Set a milestone. It should be the ticket's fix version in JIRA.

Generated by 🚫 dangerJS

@johnBartos johnBartos added this to the 8.9.1 milestone Jun 10, 2019

@jwplayer-robot

This comment has been minimized.

Copy link

commented Jun 11, 2019

⚠️ MULTI Build for commit 53d8d09 is unstable (UNSTABLE).
🏗 jwplayer build SUCCESS
🏗 jwplayer browserstack tests UNSTABLE
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial browserstack tests SUCCESS
🥒 Automated Tests UNSTABLE
🍆 Manual Tests
📺 Views

@johnBartos johnBartos merged commit 66b74d6 into master Jun 11, 2019

3 of 4 checks passed

jw7-pr-multi-opensource Build finished.
Details
Danger ⚠️ Danger found some issues. Don't worry, everything is fixable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.