Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement latency getter in default provider, mixin #3432

Merged
merged 1 commit into from Jun 11, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -78,6 +78,9 @@ const DefaultProvider = {
getBandwidthEstimate() {
return null;
},
getLiveLatency() {
return null;
},

// TODO: Deprecate provider.setControls(bool) with Flash. It's used to toggle the cursor when the swf is in focus.
setControls: noop,
@@ -54,6 +54,7 @@ const VideoListenerMixin = {
this.trigger(PROVIDER_FIRST_FRAME);
}


const timeEventObject = {
position,
duration,
@@ -70,6 +71,11 @@ const VideoListenerMixin = {
}
}

const latency = this.getLiveLatency();
if (latency !== null) {
timeEventObject.latency = latency;
}

// only emit time events when playing or seeking
if (this.state === STATE_PLAYING || this.seeking) {
this.trigger(MEDIA_TIME, timeEventObject);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.