Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of spread operator #3434

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@robwalch
Copy link
Member

commented Jun 12, 2019

This PR will...

Remove use of spread operator from unit tests.

Why is this Pull Request needed?

Babel transform uses Symbol in the transform of spread operators. Symbol is not supported in IE11. The simplest solution to the error we see in our test runs without adding additional polyfills to the player or test runner is to remove the spreads: babel/babel#7597

Remove use of spread operator
(babel transform uses Symbol, not supported in IE11 alphagov/notifications-admin#2920)

@robwalch robwalch added this to the None milestone Jun 12, 2019

@robwalch robwalch requested review from jnatalzia and zetagame Jun 12, 2019

@jwplayer-robot

This comment has been minimized.

Copy link

commented Jun 12, 2019

⚠️ MULTI Build for commit 9ee8390 is unstable (UNSTABLE).
🏗 jwplayer build SUCCESS
🏗 jwplayer unit tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial unit tests SUCCESS
🥒 Automated Tests UNSTABLE
🍆 Manual Tests
📺 Views

@johnBartos johnBartos merged commit 3382282 into master Jun 12, 2019

3 of 4 checks passed

jw7-pr-multi-opensource Build finished.
Details
Danger All green. Woo!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.