Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JW8-10171] Add localization support for Keyboard Shortcuts #3468

Merged
merged 9 commits into from Sep 11, 2019

Conversation

@DanFerrer
Copy link
Collaborator

commented Aug 21, 2019

This PR will...

  • Add int/localization support for Keyboard shortcuts
  • Support Greek (el) language

Why is this Pull Request needed?

More localization support

Are there any points in the code the reviewer needs to double check?

How do we want the shortcuts menu to look when its customized/translated and a menu item has longer text? I currently have it set to so the viewer has to scroll horizontally to view text. Should we make the menu bigger instead @aliciahurst

Are there any Pull Requests open in other repos which need to be merged with this?

jwplayer/jwplayer-commercial#6988

Addresses Issue(s):

JW8-10171

@DanFerrer DanFerrer requested a review from pajong as a code owner Aug 21, 2019

@johnBartos

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

Warnings
⚠️

🗿 Set a milestone. It should be the ticket's fix version in JIRA.

Generated by 🚫 dangerJS

@jwplayer-robot

This comment has been minimized.

Copy link

commented Aug 21, 2019

❗️ MULTI Build for commit 5298e66 did not complete (FAILURE).
🏗 jwplayer build ${JW7_OPENSOURCE_BUILD_RESULT}
🏗 jwplayer unit tests FAILURE
🏗 jwplayer-commercial build ${JW7_COMMERCIAL_BUILD_RESULT}
🏗 jwplayer-commercial unit tests ${JW7_COMMERCIAL_UNIT_TESTS_BUILD_RESULT}
🥒.js Allure Report ${JW7_COMMERCIAL_CUCUMBER_WDIO_BUILD_RESULT}
🥒 Allure Report ${JW7_COMMERCIAL_CUCUMBER_BUILD_RESULT}
🍆 Manual Tests
📺 Views

@DanFerrer DanFerrer added this to the 8.11.0 milestone Aug 21, 2019

@jwplayer-robot

This comment has been minimized.

Copy link

commented Aug 21, 2019

❗️ MULTI Build for commit 5298e66 did not complete (FAILURE).
🏗 jwplayer build ${JW7_OPENSOURCE_BUILD_RESULT}
🏗 jwplayer unit tests FAILURE
🏗 jwplayer-commercial build ${JW7_COMMERCIAL_BUILD_RESULT}
🏗 jwplayer-commercial unit tests ${JW7_COMMERCIAL_UNIT_TESTS_BUILD_RESULT}
🥒.js Allure Report ${JW7_COMMERCIAL_CUCUMBER_WDIO_BUILD_RESULT}
🥒 Allure Report ${JW7_COMMERCIAL_CUCUMBER_BUILD_RESULT}
🍆 Manual Tests
📺 Views

@jwplayer-robot

This comment has been minimized.

Copy link

commented Aug 21, 2019

⚠️ MULTI Build for commit 5298e66 is unstable (UNSTABLE).
🏗 jwplayer build SUCCESS
🏗 jwplayer unit tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial unit tests SUCCESS
🥒.js Allure Report UNSTABLE
🥒 Allure Report UNSTABLE
🍆 Manual Tests
📺 Views

@DanFerrer DanFerrer changed the title [DNM][JW8-10171] Add localization support for Keyboard Shortcuts [JW8-10171] Add localization support for Keyboard Shortcuts Sep 3, 2019

@DanFerrer DanFerrer removed the do-not-merge label Sep 3, 2019

DanFerrer added 2 commits Sep 10, 2019
@jwplayer-robot

This comment has been minimized.

Copy link

commented Sep 10, 2019

❗️ MULTI Build for commit ecb6eb5 did not complete (FAILURE).
🏗 jwplayer build SUCCESS
🏗 jwplayer unit tests SUCCESS
🏗 jwplayer-commercial build NOT_STARTED
🏗 jwplayer-commercial unit tests FAILURE
🥒.js Allure Report NOT_STARTED
🥒 Allure Report NOT_STARTED
🍆 Manual Tests
📺 Views

@jnatalzia
Copy link
Collaborator

left a comment

small nitpick but otherwise looks great!

src/css/controls/imports/modal.less Show resolved Hide resolved
src/css/controls/imports/shortcuts-tooltip.less Outdated Show resolved Hide resolved
DanFerrer added 3 commits Sep 10, 2019

@robwalch robwalch removed their request for review Sep 10, 2019

@jwplayer-robot

This comment has been minimized.

Copy link

commented Sep 10, 2019

⚠️ MULTI Build for commit b852eb1 is unstable (UNSTABLE).
🏗 jwplayer build SUCCESS
🏗 jwplayer unit tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial unit tests SUCCESS
🥒.js Allure Report UNSTABLE
🥒 Allure Report UNSTABLE
🍆 Manual Tests
📺 Views

@jwplayer-robot

This comment has been minimized.

Copy link

commented Sep 11, 2019

⚠️ MULTI Build for commit b852eb1 is unstable (UNSTABLE).
🏗 jwplayer build SUCCESS
🏗 jwplayer unit tests SUCCESS
🏗 jwplayer-commercial build SUCCESS
🏗 jwplayer-commercial unit tests SUCCESS
🥒.js Allure Report UNSTABLE
🥒 Allure Report UNSTABLE
🍆 Manual Tests
📺 Views

@DanFerrer DanFerrer merged commit 405d3a6 into master Sep 11, 2019

2 of 3 checks passed

jw7-pr-multi-opensource Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.