Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[JW8-10549] Fix the controls not autohiding on mobile #3536
This PR will...
Why is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
Are there any Pull Requests open in other repos which need to be merged with this?
As far as my understanding goes, this issue was occurring only if the user selected a control in the control bar after hitting play, but before the first userInactive event occurred.
But now that I'm thinking about it, is there a case where mobile needs both mouse and tap events?
Hmm thinking about it, there's the possibility that older devices don't support the touch events and therefore would never hit the execution path where they are removed.
Support looks really good across mobile browsers though so I don't think this concern is justified