Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truffleruby-head build is failing #396

Closed
anakinj opened this issue Dec 21, 2020 · 5 comments
Closed

truffleruby-head build is failing #396

anakinj opened this issue Dec 21, 2020 · 5 comments

Comments

@anakinj
Copy link
Member

@anakinj anakinj commented Dec 21, 2020

The truffleruby build is failing for some reason. For example https://github.com/jwt/ruby-jwt/runs/1591113294

Is there something we could do? @gogainda @eregon

@eregon
Copy link

@eregon eregon commented Dec 21, 2020

It seems to happen within SimpleCov, I'll try to investigate tomorrow.

@eregon
Copy link

@eregon eregon commented Dec 22, 2020

It's a bug of docile, doing incorrect delegation in https://github.com/ms-ati/docile/blob/f065fc32daeaf04cef387b324a8e340119ac14d0/lib/docile/fallback_context_proxy.rb#L87

It's a bug in general, as some cases with *args, **kwargs delegation don't work in CRuby 2.7 either (https://eregon.me/blog/2019/11/10/the-delegation-challenge-of-ruby27.html#ruby-3-style-delegation).
It only triggers on TruffleRuby because it is slightly closer to 2.6 semantics when it comes to **kwargs.

As a workaround, I think you could have all the coverage logic (requires and SimpleCov calls) in spec_helper.rb under if ENV['COVERAGE'] and make sure COVERAGE is not set for TruffleRuby or adapt the condition.

I'll make a PR to docile.

@anakinj
Copy link
Member Author

@anakinj anakinj commented Dec 22, 2020

Thanks for the investigation (and fix). I think we'll wait it out until a compatible version is released.

Would like to move to the other direction, always have Simplecov enabled for a better local dev experience while running the tests.

@eregon
Copy link

@eregon eregon commented Dec 22, 2020

ms-ati/docile#52 (comment) so it should work for the next build.

@anakinj
Copy link
Member Author

@anakinj anakinj commented Dec 23, 2020

Very nice, it seems to be working. Thanks a bunch!

@anakinj anakinj closed this Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants