Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JWKs for pre 2.3 rubies #382

Merged
merged 1 commit into from Dec 21, 2020
Merged

Support JWKs for pre 2.3 rubies #382

merged 1 commit into from Dec 21, 2020

Conversation

@anakinj
Copy link
Member

@anakinj anakinj commented Oct 25, 2020

This should fix the issue in #361. Even if the Rubies are EOL and stone-age we should probably still support them while the gemspec claims to support >= 2.1

Part of the problem is that the CI has not been executed for pre 2.3 versions in a while, was thinking we could maybe add the older rubies to the test matrix in #381 before we remove the support completely in the next major version of this gem.

@anakinj anakinj force-pushed the anakinj:fix-older-rubies branch 2 times, most recently from 87c68de to 699dfaa Oct 25, 2020
@anakinj
Copy link
Member Author

@anakinj anakinj commented Oct 26, 2020

2x Truffleruby builds failed because of something random. The flaky tests runs are also tagged as allow_failures in #381

@anakinj anakinj force-pushed the anakinj:fix-older-rubies branch 2 times, most recently from 35f58e2 to 4206fe7 Dec 1, 2020
@anakinj anakinj force-pushed the anakinj:fix-older-rubies branch 11 times, most recently from fd42662 to dc98e1d Dec 12, 2020
@anakinj anakinj force-pushed the anakinj:fix-older-rubies branch from dc98e1d to 6c699f1 Dec 21, 2020
@anakinj anakinj merged commit b94ad68 into jwt:master Dec 21, 2020
20 of 21 checks passed
20 of 21 checks passed
@github-actions
test (2.3, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.1, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.2, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (ruby-head, true)
Details
@github-actions
test (truffleruby-head, true) test (truffleruby-head, true)
Details
codeclimate All good!
Details
@sourcelevel-bot
sourcelevel SourceLevel did not find any new or fixed issues.
Details
@anakinj
Copy link
Member Author

@anakinj anakinj commented Dec 21, 2020

Merged this to have working CI for 2.1 and 2.2 while working on some refactorings on the JWK parts of the gem

@anakinj anakinj deleted the anakinj:fix-older-rubies branch Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant