Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JWT::JWK::EC compatible with Ruby 2.3 #386

Merged
merged 2 commits into from Dec 12, 2020
Merged

Conversation

@anakinj
Copy link
Member

@anakinj anakinj commented Dec 2, 2020

Seems that the OpenSSL::PKey::EC#generate_key! method is not available in Ruby 2.3 without installing the openssl gem.

This other PR that is making the CIactually test the supported Rubies and combinations revealed that:
https://travis-ci.org/github/jwt/ruby-jwt/jobs/747060754

@anakinj anakinj force-pushed the anakinj:fix-ec-for-23 branch from 664673c to f75404d Dec 4, 2020
@sourcelevel-bot
Copy link

@sourcelevel-bot sourcelevel-bot bot commented Dec 4, 2020

SourceLevel has finished reviewing this Pull Request and has found:

  • 2 possible new issues (including those that may have been commented here).

See more details about this review.

@anakinj
Copy link
Member Author

@anakinj anakinj commented Dec 4, 2020

@richardlarocque Are you OK with these changes. Unfortunately think we need to support the EOL rubies as long as the gemspec claims we do. Hoping to drop support for the oldies soon

@anakinj anakinj changed the title Make tests for the JWT::JWK::EC compatible with Ruby 2.3 Make JWT::JWK::EC compatible with Ruby 2.3 Dec 4, 2020
@anakinj
Copy link
Member Author

@anakinj anakinj commented Dec 12, 2020

I'll go on and merge this to get the tests green.

@anakinj anakinj merged commit 7475c50 into jwt:master Dec 12, 2020
19 of 22 checks passed
19 of 22 checks passed
@github-actions
test (2.3, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.1, true) test (2.1, true)
Details
@github-actions
test (2.2, true) test (2.2, true)
Details
@github-actions
test (ruby-head, true)
Details
@github-actions
test (truffleruby-head, true)
Details
codeclimate 1 issue to fix
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sourcelevel-bot
sourcelevel SourceLevel has found 2 possible new issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant