Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rubocop locally and on ci #390

Merged
merged 1 commit into from Dec 23, 2020
Merged

Enable rubocop locally and on ci #390

merged 1 commit into from Dec 23, 2020

Conversation

@anakinj
Copy link
Member

@anakinj anakinj commented Dec 14, 2020

Been struggling with sourcelevel-bot spamming PRs with comments about linting issues like extra whitespaces and such.

This PR adds the possibility to run rubocop locally to catch issues early in the process.

The version should be the same as Codeclimate is using(https://docs.codeclimate.com/docs/rubocop)

@sourcelevel-bot
Copy link

@sourcelevel-bot sourcelevel-bot bot commented Dec 14, 2020

SourceLevel has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).
  • 5 fixed issues! 🎉

See more details about this review.

@anakinj anakinj force-pushed the anakinj:enable-rubocop branch from 99d7186 to 6f14ed7 Dec 21, 2020
@anakinj anakinj force-pushed the anakinj:enable-rubocop branch from 6f14ed7 to 9b07e84 Dec 21, 2020
@anakinj
Copy link
Member Author

@anakinj anakinj commented Dec 21, 2020

@excpt Im thinking of merging this to improve the local experience when developing the gem.

@anakinj anakinj merged commit 10b7dd4 into jwt:master Dec 23, 2020
22 checks passed
22 checks passed
@github-actions
RuboCop
Details
@github-actions
test (2.3, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.1, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.2, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (ruby-head, true)
Details
@github-actions
test (truffleruby-head, true)
Details
codeclimate 8 fixed issues
Details
@sourcelevel-bot
sourcelevel SourceLevel has found 1 possible new issue and 5 fixed issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant