Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recommend installing gem with sudo #391

Merged
merged 1 commit into from Dec 15, 2020
Merged

Don't recommend installing gem with sudo #391

merged 1 commit into from Dec 15, 2020

Conversation

@tjschuck
Copy link
Contributor

@tjschuck tjschuck commented Dec 15, 2020

Not installing gems using sudo has long been considered a best practice.

The original post that popularized this from 10 years has since gone offline, but it's cached here. But since everything old is new again, this even came up again in this week's Ruby Weekly just this week (linking to this new post).

Here are a couple more classics of the genre.

_Not_ installing gems using `sudo` has long been considered a best practice.

The original post that popularized this from 10 years has since gone offline, but [it's cached here](https://web.archive.org/web/20101101064608/http://all-thing.net/sudo-gem-install-considered-harmful).  But since everything old is new again, this even came up again in [this week's Ruby Weekly](https://rubyweekly.com/issues/531) just this week (linking to [this new post](https://www.moncefbelyamani.com/why-you-should-never-use-sudo-to-install-ruby-gems/)).

Here are a couple more [classics](https://thoughtbot.com/blog/psa-do-not-use-system-ruby) of the [genre](https://stackoverflow.com/questions/2119064/sudo-gem-install-or-gem-install-and-gem-locations).
@sourcelevel-bot
Copy link

@sourcelevel-bot sourcelevel-bot bot commented Dec 15, 2020

Hello, @tjschuck! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@anakinj anakinj merged commit ef8718b into jwt:master Dec 15, 2020
19 checks passed
19 checks passed
@github-actions
test (2.3, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (ruby-head, true)
Details
@github-actions
test (truffleruby-head, true)
Details
codeclimate All good!
Details
@sourcelevel-bot
sourcelevel SourceLevel did not find any new or fixed issues.
Details
@anakinj
Copy link
Member

@anakinj anakinj commented Dec 15, 2020

Thank you @tjschuck!

@tjschuck tjschuck deleted the tjschuck:patch-1 branch Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants